diff options
author | 2020-12-23 12:00:55 +0100 | |
---|---|---|
committer | 2021-01-10 15:57:39 -0800 | |
commit | 27810f321743e4e3c341e3d89257d82fc23946e6 (patch) | |
tree | 0dbf58b824d27f04a184c73cbcd80471449b9722 /qt-models/gpslistmodel.cpp | |
parent | 72427adc1c063ae5de08f4d92dc79824f6227614 (diff) | |
download | subsurface-27810f321743e4e3c341e3d89257d82fc23946e6.tar.gz |
profile: remove model parameter from TankItem::setData()
This one is extremely obscure: TankItem::setData(), which is
called on every replot, was passed the DivePlotDataModel,
even though it doesn't access that model at all.
Instead, it connect()s to the model to stay informed of changes
to the data. First of all, this should obviously be done
once in the constructor, not on every replot.
But also, the setData() function is called on every replot
one lines before sending the model-changed signal.
Thus, the tankitem was always repainted twice.
Just remove the whole connect() thing and go for a more
deterministic model. Should the tankbar not be repainted
anywhere, add the appropriate calls there.
Accordingly rename the "modelDataChanged" slot to "replot".
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/gpslistmodel.cpp')
0 files changed, 0 insertions, 0 deletions