diff options
| author |  Berthold Stoeger <bstoeger@mail.tuwien.ac.at> | 2017-12-20 20:00:26 +0100 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2017-12-24 11:04:10 -0800 |
| commit | 130f109442de7b5b047cc10b0e4534169459d291 (patch) | |
| tree | d10dfc4bafbabd6a2beb44d0d109ca8543974a5f /qt-models/models.cpp | |
| parent | 4c4222d61119e437b4b79e36903a5b357756de21 (diff) | |
| download | subsurface-130f109442de7b5b047cc10b0e4534169459d291.tar.gz | |
Remove superfluous QScopedPointer<>s in singletons
There was a curious pattern of singletons being implemented based on
QScopedPointer<>s. This is an unnecessary level of indirection:
The lifetime of the smart pointer is the same as that of the
pointed-to object. Therefore, replace these pointers by the respective
objects.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models/models.cpp')
| -rw-r--r-- | qt-models/models.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/qt-models/models.cpp b/qt-models/models.cpp index fa9519600..4f4df6425 100644 --- a/qt-models/models.cpp +++ b/qt-models/models.cpp @@ -32,8 +32,8 @@ Qt::ItemFlags GasSelectionModel::flags(const QModelIndex &index) const GasSelectionModel *GasSelectionModel::instance() { - static QScopedPointer<GasSelectionModel> self(new GasSelectionModel()); - return self.data(); + static GasSelectionModel self; + return &self; } //TODO: Remove this #include here when the issue below is fixed. |