summaryrefslogtreecommitdiffstats
path: root/qt-models
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-06-30 13:52:06 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-07-03 01:55:47 +0800
commit37c6fe44e4839c226e9514887974f22fd86831e0 (patch)
tree7679c8eb68523f3f85defea8c6c4c5b454d8f832 /qt-models
parent988d6682f201ac39796d4f351340783a6c59b053 (diff)
downloadsubsurface-37c6fe44e4839c226e9514887974f22fd86831e0.tar.gz
Dive pictures: remove unnecessary check for no dives
This fixes a bug introduced in fbe1144eaf7e800a014c7a97b846835ba9f3bc7f: For an empty log, in DivePictureModel::updateDivePictures() beginResetModel() would be called without a corresponding endResetModel(). It is unclear whether this can ever be hit, because in the no-dives case, at least in the desktop version no profile is shown. Note, that this makes the check double-unnecessary. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'qt-models')
-rw-r--r--qt-models/divepicturemodel.cpp4
1 files changed, 0 insertions, 4 deletions
diff --git a/qt-models/divepicturemodel.cpp b/qt-models/divepicturemodel.cpp
index 541f88027..f84146168 100644
--- a/qt-models/divepicturemodel.cpp
+++ b/qt-models/divepicturemodel.cpp
@@ -64,10 +64,6 @@ void DivePictureModel::updateDivePictures()
Thumbnailer::instance()->clearWorkQueue();
}
- // if the dive_table is empty, quit
- if (dive_table.nr == 0)
- return;
-
int i;
struct dive *dive;
for_each_dive (i, dive) {