diff options
| author |  Rolf Eike Beer <eike@sf-mail.de> | 2019-04-01 22:15:19 +0200 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2019-04-12 12:59:17 +0300 |
| commit | c4c8094e32ad78dee558a80584470172f48c45b1 (patch) | |
| tree | 4fede2acf0f1a3cee2182d96b1b3efa33e4fd8ff /qt-models | |
| parent | 2b9ca488fd18dc9d65d42dc5900e120a07e5b3f6 (diff) | |
| download | subsurface-c4c8094e32ad78dee558a80584470172f48c45b1.tar.gz | |
get rid of some foreach and Q_FOREACH constructs
See https://www.kdab.com/goodbye-q_foreach/
This is reduced to the places where the container is const or can be made const
without the need to always introduce an extra variable. Sadly qAsConst (Qt 5.7)
and std::as_const (C++17) are not available in all supported setups.
Also do some minor cleanups along the way.
Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
Diffstat (limited to 'qt-models')
| -rw-r--r-- | qt-models/divelistmodel.cpp | 4 | ||||
| -rw-r--r-- | qt-models/divelistmodel.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/qt-models/divelistmodel.cpp b/qt-models/divelistmodel.cpp index 6edb69705..4d66c5406 100644 --- a/qt-models/divelistmodel.cpp +++ b/qt-models/divelistmodel.cpp @@ -144,12 +144,12 @@ DiveListModel::DiveListModel(QObject *parent) : QAbstractListModel(parent) m_instance = this; } -void DiveListModel::addDive(QList<dive *>listOfDives) +void DiveListModel::addDive(const QList<dive *> &listOfDives) { if (listOfDives.isEmpty()) return; beginInsertRows(QModelIndex(), rowCount(), rowCount() + listOfDives.count() - 1); - foreach (dive *d, listOfDives) { + for (dive *d: listOfDives) { m_dives.append(new DiveObjectHelper(d)); } endInsertRows(); diff --git a/qt-models/divelistmodel.h b/qt-models/divelistmodel.h index 50b45caa9..37d3513bf 100644 --- a/qt-models/divelistmodel.h +++ b/qt-models/divelistmodel.h @@ -44,7 +44,7 @@ public: static DiveListModel *instance(); DiveListModel(QObject *parent = 0); - void addDive(QList<dive *> listOfDives); + void addDive(const QList<dive *> &listOfDives); void addAllDives(); void insertDive(int i, DiveObjectHelper *newDive); void removeDive(int i); |