summaryrefslogtreecommitdiffstats
path: root/qt-ui/divecomputermanagementdialog.cpp
diff options
context:
space:
mode:
authorGravatar Thiago Macieira <thiago@macieira.org>2013-11-30 09:18:04 -0800
committerGravatar Dirk Hohndel <dirk@hohndel.org>2013-11-30 09:28:42 -0800
commitb22f1da59e37ff4ba871fb2d6c72ee3ec87b4c5b (patch)
tree6548f4639be3261e2db66657b50a6fd095d3a577 /qt-ui/divecomputermanagementdialog.cpp
parentbd7ded88940995ebbb46fc6983ba9cfd179e55e0 (diff)
downloadsubsurface-b22f1da59e37ff4ba871fb2d6c72ee3ec87b4c5b.tar.gz
Fix all leak-at-exit from singletons in Subsurface
Subsurface creates a lot of singleton instances on demand, but nothing ever deleted them. Since they are singletons, these memory allocations are technically not leaks. However, they clutter the output in valgrind and other memory analysers, hiding the real issues. The solution is to delete these items at exit. For the models and for gettextFromC, the solution is to use a QScopedPointer, which will delete its payload when it gets destroyed. For the dialogs and other widgets, we can't do that: they need to be deleted before QApplication exits, so we just set the parent in all of them to the main window. Signed-off-by: Thiago Macieira <thiago@macieira.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/divecomputermanagementdialog.cpp')
-rw-r--r--qt-ui/divecomputermanagementdialog.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/qt-ui/divecomputermanagementdialog.cpp b/qt-ui/divecomputermanagementdialog.cpp
index 883c8e9a7..af27e914f 100644
--- a/qt-ui/divecomputermanagementdialog.cpp
+++ b/qt-ui/divecomputermanagementdialog.cpp
@@ -23,7 +23,7 @@ void DiveComputerManagementDialog::init()
DiveComputerManagementDialog* DiveComputerManagementDialog::instance()
{
- static DiveComputerManagementDialog *self = new DiveComputerManagementDialog();
+ static DiveComputerManagementDialog *self = new DiveComputerManagementDialog(mainWindow());
self->setAttribute(Qt::WA_QuitOnClose, false);
return self;
}