diff options
| author |  Tomaz Canabrava <tomaz.canabrava@intel.com> | 2014-07-15 14:43:20 -0300 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2014-07-15 16:55:10 -0700 |
| commit | d993684fec07ccf6c3135e16286cd87e045f142c (patch) | |
| tree | 03f59a88719625ca03cd8fccba3f17ddbc85c569 /qt-ui/divelistview.cpp | |
| parent | eaacac321743434ce8610b4b61f56a3fe4a63567 (diff) | |
| download | subsurface-d993684fec07ccf6c3135e16286cd87e045f142c.tar.gz | |
Do not create a backup for Q_FOREACH container
Q_FOREACH will expand and already creates a copy of the
contained container, so this is just a waste of cpu cycles
and also increases a tiny bit the memory consumption.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/divelistview.cpp')
| -rw-r--r-- | qt-ui/divelistview.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp index eb56d2e03..5fde4c45f 100644 --- a/qt-ui/divelistview.cpp +++ b/qt-ui/divelistview.cpp @@ -199,9 +199,8 @@ void DiveListView::unselectDives() QList<dive_trip_t *> DiveListView::selectedTrips() { - QModelIndexList indexes = selectionModel()->selectedRows(); QList<dive_trip_t *> ret; - Q_FOREACH (const QModelIndex &index, indexes) { + Q_FOREACH (const QModelIndex &index, selectionModel()->selectedRows()) { dive_trip_t *trip = static_cast<dive_trip_t *>(index.data(DiveTripModel::TRIP_ROLE).value<void *>()); if (!trip) continue; |