diff options
author | Tomaz Canabrava <tomaz.canabrava@intel.com> | 2014-05-10 21:37:18 -0300 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2014-05-11 01:57:00 -0700 |
commit | cf848e52330fa0bca2ccc0fb5de5f2a4033fbafa (patch) | |
tree | 7801e74e8ecc0be25849993294154c8322bd42b8 /qt-ui/globe.cpp | |
parent | 3b7624ff464b323fc3c271787a36faa1e97a7b27 (diff) | |
download | subsurface-cf848e52330fa0bca2ccc0fb5de5f2a4033fbafa.tar.gz |
Correct the usage of std::string and QString
QStrings shouldn't be == "" to check for empty string, use .isEmpty()
QStrings shouldn't be != "" to check for non empty, use .size()
std::string shouldn't be cleared with = "", use .clear()
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/globe.cpp')
-rw-r--r-- | qt-ui/globe.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/qt-ui/globe.cpp b/qt-ui/globe.cpp index 9f66e2bd1..1101500d3 100644 --- a/qt-ui/globe.cpp +++ b/qt-ui/globe.cpp @@ -48,11 +48,11 @@ GlobeGPS::GlobeGPS(QWidget *parent) : MarbleWidget(parent), QDir marble; if (!list.contains("earth/googlesat/googlesat.dgml")) { subsurfaceDataPath = getSubsurfaceDataPath("marbledata"); - if (subsurfaceDataPath != "") { + if (subsurfaceDataPath.size()) { MarbleDirs::setMarbleDataPath(subsurfaceDataPath); } else { subsurfaceDataPath = getSubsurfaceDataPath("data"); - if (subsurfaceDataPath != "") + if (subsurfaceDataPath.size()) MarbleDirs::setMarbleDataPath(subsurfaceDataPath); } } |