summaryrefslogtreecommitdiffstats
path: root/qt-ui/maintab.cpp
diff options
context:
space:
mode:
authorGravatar Tomaz Canabrava <tomaz.canabrava@intel.com>2014-07-15 14:43:20 -0300
committerGravatar Dirk Hohndel <dirk@hohndel.org>2014-07-15 16:55:10 -0700
commitd993684fec07ccf6c3135e16286cd87e045f142c (patch)
tree03f59a88719625ca03cd8fccba3f17ddbc85c569 /qt-ui/maintab.cpp
parenteaacac321743434ce8610b4b61f56a3fe4a63567 (diff)
downloadsubsurface-d993684fec07ccf6c3135e16286cd87e045f142c.tar.gz
Do not create a backup for Q_FOREACH container
Q_FOREACH will expand and already creates a copy of the contained container, so this is just a waste of cpu cycles and also increases a tiny bit the memory consumption. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/maintab.cpp')
-rw-r--r--qt-ui/maintab.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/qt-ui/maintab.cpp b/qt-ui/maintab.cpp
index a7950c074..050cf32f6 100644
--- a/qt-ui/maintab.cpp
+++ b/qt-ui/maintab.cpp
@@ -80,8 +80,7 @@ MainTab::MainTab(QWidget *parent) : QTabWidget(parent),
ui.timeEdit->installEventFilter(this);
ui.tagWidget->installEventFilter(this);
- QList<QObject *> statisticsTabWidgets = ui.statisticsTab->children();
- Q_FOREACH (QObject *obj, statisticsTabWidgets) {
+ Q_FOREACH (QObject *obj, ui.statisticsTab->children()) {
QLabel *label = qobject_cast<QLabel *>(obj);
if (label)
label->setAlignment(Qt::AlignHCenter);