diff options
| author |  Tomaz Canabrava <tomaz.canabrava@intel.com> | 2014-05-12 14:22:46 -0300 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2014-05-13 09:24:37 +0900 |
| commit | e0c0ac5d5c7c218011278fbe57da291a7e10c8eb (patch) | |
| tree | 85ad06d20621a0bed01ee4266e5e4f6bbc8e6838 /qt-ui/profile/diveplotdatamodel.cpp | |
| parent | e1971e9425dfc5266fa1e15579ff36d2b17658da (diff) | |
| download | subsurface-e0c0ac5d5c7c218011278fbe57da291a7e10c8eb.tar.gz | |
Rename getDiveById to get_dive_by_id to keep current c code organized.
This commit renames getDiveById to get_dive_by_id, and it also removes the
Q_ASSERTS and if(!dive) return that the callers of this function were
calling. If it has a Q_ASSERT this means that the dive must exist,
so checking for nullness was bogus too. I've changed the assert (done
in a silly C-Way.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/profile/diveplotdatamodel.cpp')
| -rw-r--r-- | qt-ui/profile/diveplotdatamodel.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/qt-ui/profile/diveplotdatamodel.cpp b/qt-ui/profile/diveplotdatamodel.cpp index ad2859b9e..990564fbb 100644 --- a/qt-ui/profile/diveplotdatamodel.cpp +++ b/qt-ui/profile/diveplotdatamodel.cpp @@ -178,9 +178,7 @@ void DivePlotDataModel::emitDataChanged() void DivePlotDataModel::calculateDecompression() { - struct dive *d = getDiveById(id()); - if (!d) - return; + struct dive *d = get_dive_by_diveid(id()); struct divecomputer *dc = select_dc(d); init_decompression(d); calculate_deco_information(d, dc, &pInfo, false); |