diff options
author | Tomaz Canabrava <tcanabrava@kde.org> | 2014-02-04 19:21:57 -0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2014-02-05 06:30:33 -0800 |
commit | 7b9400685d86eee904b07471353435f34fec3686 (patch) | |
tree | c0a2aa0f7b32864b8cac6f4e827ac09f18e34e40 /qt-ui/profile/diveprofileitem.cpp | |
parent | 25b0a846af1d4661d16c3de9784879ad44476d08 (diff) | |
download | subsurface-7b9400685d86eee904b07471353435f34fec3686.tar.gz |
Optimizations and fixes on the new profile.
This patch optimizes a few items when hitting the
'save preferences' dialog, since when a preference is
modified, all the items try to reload their visual
based on wether a preference changed or not, the correct
code for 'hey, my pref changed, let's update' needed
to be done.
now the axis will only set a new maximum if it's different
from the old one ( and thus, going to a new dive with
the same maxdepth or maxtime as the old one will not touch
their axis, not triggering gratuitous animations. )
also, the 'incr by 3m' was not being called - it seems
that our 'syncsettings' method is not storing things on
the 'prefs' global var. I added just for the incr by 3m
case, but it's something that we need to check later.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/profile/diveprofileitem.cpp')
-rw-r--r-- | qt-ui/profile/diveprofileitem.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/qt-ui/profile/diveprofileitem.cpp b/qt-ui/profile/diveprofileitem.cpp index 05791eed5..11d80e96b 100644 --- a/qt-ui/profile/diveprofileitem.cpp +++ b/qt-ui/profile/diveprofileitem.cpp @@ -471,9 +471,8 @@ void DiveCalculatedCeiling::preferencesChanged() if ( dataModel && is3mIncrement != shouldShow3mIncrement){ // recalculate that part. dataModel->calculateDecompression(); - is3mIncrement = shouldShow3mIncrement; } - + is3mIncrement = shouldShow3mIncrement; setVisible(s.value("calcceiling").toBool()); } |