diff options
author | Dirk Hohndel <dirk@hohndel.org> | 2013-06-17 15:58:26 -0700 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2013-06-18 00:24:28 -0700 |
commit | 29b242c70349cbd67aacc3e4f1206630d22c54eb (patch) | |
tree | 21edbec2770ddf9fb9eb333429c013aefca2f99d /qt-ui/profilegraphics.cpp | |
parent | 14ccbbf6e87b69267426ae69c402c1bae70ec5d5 (diff) | |
download | subsurface-29b242c70349cbd67aacc3e4f1206630d22c54eb.tar.gz |
Converting the device_info list into a Qt data structure
This data structure was quite fragile and made 'undo' when editing
rather hard to implement. So instead I decided to turn this into a
QMultiMap which seemed like the ideal data structure for it.
This map holds all the dive computer related data indexed by the model. As
QMultiMap it allows multiple entries per key (model string) and
disambiguates between them with the deviceId.
This commit turned out much larger than I wanted. But I didn't manage to
find a clean way to break it up and make the pieces make sense.
So this brings back the Ok / Cancel button for the dive computer edit
dialog. And it makes those two buttons actually do the right thing (which
is what started this whole process). For this to work we simply copy the
map to a working copy and do all edits on that one - and then copy that
over the 'real' map when we accept the changes.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/profilegraphics.cpp')
-rw-r--r-- | qt-ui/profilegraphics.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/qt-ui/profilegraphics.cpp b/qt-ui/profilegraphics.cpp index 126690750..e580a2b44 100644 --- a/qt-ui/profilegraphics.cpp +++ b/qt-ui/profilegraphics.cpp @@ -21,6 +21,7 @@ #include "../dive.h" #include "../profile.h" #include "../device.h" +#include "../helpers.h" #include <libdivecomputer/parser.h> #include <libdivecomputer/version.h> @@ -273,7 +274,7 @@ void ProfileGraphicsView::plot(struct dive *d, bool forceRedraw) dc = fake_dc(dc); } - QString nick(get_dc_nickname(dc->model, dc->deviceid)); + QString nick = get_dc_nickname(dc->model, dc->deviceid); if (nick.isEmpty()) nick = QString(dc->model); |