diff options
author | Tomaz Canabrava <tcanabrava@kde.org> | 2014-04-16 23:56:42 -0300 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2014-04-17 08:33:51 -0700 |
commit | f14c14c383763c73de1a6ec681b017517235f2f6 (patch) | |
tree | 3c9c624e51c8e602a8ba085d56411c839fc05b80 /qt-ui/subsurfacewebservices.cpp | |
parent | 1a1cbc296be806a2117a5969443917d96bcb096a (diff) | |
download | subsurface-f14c14c383763c73de1a6ec681b017517235f2f6.tar.gz |
Mark a lot of TODO's where I think it should be moved to C code.
This marks a lot of todo's where I think there's core stuff being mangled
on the interface - we should remove this from the interface to make
testing and maintenability easier.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/subsurfacewebservices.cpp')
-rw-r--r-- | qt-ui/subsurfacewebservices.cpp | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp index 1b8eab129..50f195635 100644 --- a/qt-ui/subsurfacewebservices.cpp +++ b/qt-ui/subsurfacewebservices.cpp @@ -40,7 +40,7 @@ static bool is_automatic_fix(struct dive *gpsfix) } #define SAME_GROUP 6 * 3600 // six hours - +//TODO: C Code. static functions are not good if we plan to have a test for them. static bool merge_locations_into_dives(void) { int i, nr = 0, changed = 0; @@ -94,7 +94,7 @@ static bool merge_locations_into_dives(void) } return changed > 0; } - +//TODO: C-code. static void clear_table(struct dive_table *table) { int i; @@ -103,6 +103,7 @@ static void clear_table(struct dive_table *table) table->nr = 0; } +// TODO: This looks like should be ported to C code. or a big part of it. bool DivelogsDeWebServices::prepare_dives_for_divelogs(const QString &tempfile, const bool selected) { static const char errPrefix[] = "divelog.de-upload:"; @@ -451,6 +452,7 @@ void SubsurfaceWebServices::setStatusText(int status) ui.status->setText(text); } +//TODO: C-Code. /* requires that there is a <download> or <error> tag under the <root> tag */ void SubsurfaceWebServices::download_dialog_traverse_xml(xmlNodePtr node, unsigned int *download_status) { @@ -467,6 +469,7 @@ void SubsurfaceWebServices::download_dialog_traverse_xml(xmlNodePtr node, unsign } } +// TODO: C-Code unsigned int SubsurfaceWebServices::download_dialog_parse_response(const QByteArray &xml) { xmlNodePtr root; |