diff options
| author |  Tomaz Canabrava <tomaz.canabrava@intel.com> | 2014-07-16 17:20:21 -0300 |
|---|---|---|
| committer |  Dirk Hohndel <dirk@hohndel.org> | 2014-07-16 13:56:46 -0700 |
| commit | 0dd40b7a514a2ea02c2f4160a74b23c0fb9a41dd (patch) | |
| tree | 466d6e7e87c7a8a808a87484555431dad535e13d /qt-ui/usersurvey.h | |
| parent | bbbb4ced241c156a2500334ff29ba0ea496d3811 (diff) | |
| download | subsurface-0dd40b7a514a2ea02c2f4160a74b23c0fb9a41dd.tar.gz | |
Rely on QNetworkReply finished() signal instead of AccessManager one
The access manager is only one, while we can make requests from
different parts of the application, so relying on the manager
finished() signal to see if something was done or not was a
not very good move.
The QNetworkReply is created when a get() is invocked on the
AccessManager and that's unique. connect it's finished()
signal instead.
bonus: code cleanup.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'qt-ui/usersurvey.h')
| -rw-r--r-- | qt-ui/usersurvey.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/qt-ui/usersurvey.h b/qt-ui/usersurvey.h index b9221852b..8dacb7bb8 100644 --- a/qt-ui/usersurvey.h +++ b/qt-ui/usersurvey.h @@ -20,13 +20,10 @@ private slots: void on_buttonBox_accepted(); void on_buttonBox_rejected(); - void requestReceived(QNetworkReply *reply); + void requestReceived(); private: Ui::UserSurvey *ui; QString os; - QString checkboxes; - QString suggestions; - QNetworkAccessManager *manager; }; #endif // USERSURVEY_H |