C++ Correctness and code cleanup.

Use const-reference where we can gain a bit of speed from that
and clear an else { if {}} by using else if.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

2 files changed, 5 insertions, 7 deletions

diff --git a/qt-ui/groupedlineedit.cpp b/qt-ui/groupedlineedit.cpp
index 28758e02f..4867089f4 100644
--- a/qt-ui/groupedlineedit.cpp
+++ b/qt-ui/groupedlineedit.cpp
@@ -106,7 +106,7 @@ void GroupedLineEdit::removeAllColors()
 QStringList GroupedLineEdit::getBlockStringList()
 {
 	QStringList retList;
-	foreach (Private::Block block, d->blocks)
+	foreach (const Private::Block &block, d->blocks)
 		retList.append(block.text);
 	return retList;
 }
diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp
index 194ea1acb..bbee51b8b 100644
--- a/qt-ui/mainwindow.cpp
+++ b/qt-ui/mainwindow.cpp
@@ -1025,18 +1025,16 @@ void MainWindow::removeRecentFile(QStringList failedFiles)
 		}
 	}
 
-	foreach (QString file, failedFiles)
+	foreach (const QString &file, failedFiles)
 		files.removeAll(file);
 
 	for (int c = 1; c <= 4; c++) {
 		QString key = QString("File_%1").arg(c);
 
-		if (files.count() >= c) {
+		if (files.count() >= c)
 			s.setValue(key, files.at(c - 1));
-		} else {
-			if (s.contains(key))
-				s.remove(key);
-		}
+		else if (s.contains(key))
+			s.remove(key);
 	}
 
 	s.endGroup();