diff options
author | Tomaz Canabrava <tomaz.canabrava@intel.com> | 2016-01-26 12:28:38 -0200 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2016-01-26 09:51:14 -0800 |
commit | ccf29679ae6e9eebf63a925dc99021c8f1e402dc (patch) | |
tree | b3fe1510f355a2b7e272928882d676f476d43b5b /subsurface-core/cloudstorage.h | |
parent | 8b7427c56d487a9f41afef01b6d7952e8e1e15af (diff) | |
download | subsurface-ccf29679ae6e9eebf63a925dc99021c8f1e402dc.tar.gz |
Fix usage of QString
1 - Pass QStrings by const-ref
2 - Don't initialize empty strings with "", they are empty
by default
3 - Don't compare empty strings with "", use .isEmpty()
4 - don't append or prepend " ", use QChar(' ')
5 - don't compare QStrings with "constant string", use
QLatin1String(" constant string" )
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'subsurface-core/cloudstorage.h')
-rw-r--r-- | subsurface-core/cloudstorage.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/subsurface-core/cloudstorage.h b/subsurface-core/cloudstorage.h index b4b21dd2a..6addb739d 100644 --- a/subsurface-core/cloudstorage.h +++ b/subsurface-core/cloudstorage.h @@ -7,7 +7,7 @@ class CloudStorageAuthenticate : public QObject { Q_OBJECT public: - QNetworkReply* backend(QString email, QString password, QString pin = "", QString newpasswd = ""); + QNetworkReply* backend(const QString& email,const QString& password,const QString& pin = QString(),const QString& newpasswd = QString()); explicit CloudStorageAuthenticate(QObject *parent); signals: void finishedAuthenticate(); |