summaryrefslogtreecommitdiffstats
path: root/subsurface-desktop-main.cpp
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2018-09-08 19:58:11 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2018-10-11 16:22:27 -0700
commitb19adecb9f679b3b4523d679e65dedc2849d50e6 (patch)
tree4002a578dcfab0470e1bff0c27b6fa25a2484aa3 /subsurface-desktop-main.cpp
parente0fcf99d0ac3ec23e6009a55b6e59c47c668081b (diff)
downloadsubsurface-b19adecb9f679b3b4523d679e65dedc2849d50e6.tar.gz
Undo: make adding of planned dive undo-able
Planned dives were still added by directly calling core code. This could confuse the undo-machinery, leading to crashes. Instead, use the proper undo-command. The problem is that as opposed to the other AddDive-commands, planned dives may belong to a trip. Thus, the interface to the AddDive command was changed to respect the divetrip field. Make sure that the other callers reset that field (actually, it should never be set). Add a comment describing the perhaps surprising interface (the passed-in dive, usually displayed dive, is reset). Moreover, a dive cloned in the planner is not assigned a new number. Thus, add an argument to the AddDive-command, which expresses whether a new number should be generated for the to-be-added dive. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'subsurface-desktop-main.cpp')
0 files changed, 0 insertions, 0 deletions