summaryrefslogtreecommitdiffstats
path: root/subsurface.debug
diff options
context:
space:
mode:
authorGravatar Berthold Stoeger <bstoeger@mail.tuwien.ac.at>2020-03-09 17:56:32 +0100
committerGravatar Dirk Hohndel <dirk@hohndel.org>2020-03-09 12:11:01 -0700
commit2fcd4fff0a44340c1d22857373d2e88cf6641160 (patch)
tree5b4c4afa0c15a7545356ca35e0fa635e5899f854 /subsurface.debug
parentb15b9c6cd0e8d83ec12a868c10cf184217f51309 (diff)
downloadsubsurface-2fcd4fff0a44340c1d22857373d2e88cf6641160.tar.gz
cleanup: fix NOCLOUD_LOCALSTORAGE leak
The macro NOCLOUD_LOCALSTORAGE creates the path to the local git repository as a C-string. None of the users were freeing the string and thus leaking memory. Replace the macro by an inline function that creates a QString and pass down to C-functions using the qPrintable() macro. Note that every qPrintable() invocation does a UTF16->UTF8 conversion. This could be avoided by either using a std::string or a QByteArray. However, we are talking about microseconds of CPU time in operations that typically take seconds. Not worth it. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Diffstat (limited to 'subsurface.debug')
0 files changed, 0 insertions, 0 deletions