Fix memory handling for taxonomy data

The way we freed things and cleared out the variables potentially left
dangling data behind and could end up calling free on garbage data,
leading to random crashes.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 6 insertions, 4 deletions

diff --git a/taxonomy.c b/taxonomy.c
index b72616faf..40af9fd44 100644
--- a/taxonomy.c
+++ b/taxonomy.c
@@ -28,11 +28,13 @@ struct taxonomy *alloc_taxonomy()
 	return calloc(TC_NR_CATEGORIES, sizeof(struct taxonomy));
 }
 
-void free_taxonomy(struct taxonomy *t)
+void free_taxonomy(struct taxonomy_data *t)
 {
 	if (t) {
-		for (int i = 0; i < TC_NR_CATEGORIES; i++)
-			free((void *)t[i].value);
-		free(t);
+		for (int i = 0; i < t->nr; i++)
+			free((void *)t->category[i].value);
+		free(t->category);
+		t->category = NULL;
+		t->nr = 0;
 	}
 }