summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorGravatar Tomaz Canabrava <tcanabrava@kde.org>2016-10-15 20:26:34 +0200
committerGravatar Dirk Hohndel <dirk@hohndel.org>2016-10-15 12:24:05 -0700
commit9c4b0170bfc321a31c6f3d0f7cd34edfa74fe1f4 (patch)
tree951fd3e66b4200dff28bbe80bef3ce458955d248 /tests
parentc1fbc70d83cb8a3755120c5d0203a20806b94c6d (diff)
downloadsubsurface-9c4b0170bfc321a31c6f3d0f7cd34edfa74fe1f4.tar.gz
Make all current written tests pass
Fixes a couple of issues with the tests. Also, a type in prefs.h is "short" while it's actually a boolean, this made me write the wrong testcase for this. Fixed this by setting the Qt wrapper to bool, but I didn't changed the c implementation because I tought I could break something. Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'tests')
-rw-r--r--tests/testpreferences.cpp10
1 files changed, 5 insertions, 5 deletions
diff --git a/tests/testpreferences.cpp b/tests/testpreferences.cpp
index 069e78db9..684795891 100644
--- a/tests/testpreferences.cpp
+++ b/tests/testpreferences.cpp
@@ -284,29 +284,29 @@ void TestPreferences::testPreferences()
auto proxy = pref->proxy;
proxy->setType(2);
proxy->setPort(80);
- proxy->setAuth((short) 5);
+ proxy->setAuth(true);
proxy->setHost("localhost");
proxy->setUser("unknown");
proxy->setPass("secret");
TEST(proxy->type(),2);
TEST(proxy->port(),80);
- TEST(proxy->auth(),(short) 5);
+ TEST(proxy->auth(),true);
TEST(proxy->host(),QStringLiteral("localhost"));
TEST(proxy->user(),QStringLiteral("unknown"));
TEST(proxy->pass(),QStringLiteral("secret"));
proxy->setType(3);
proxy->setPort(8080);
- proxy->setAuth((short) 6);
+ proxy->setAuth(false);
proxy->setHost("127.0.0.1");
proxy->setUser("unknown_1");
proxy->setPass("secret_1");
TEST(proxy->type(),3);
TEST(proxy->port(),8080);
- TEST(proxy->auth(),(short) 6);
- TEST(proxy->host(),QStringLiteral("localhost_1"));
+ TEST(proxy->auth(),false);
+ TEST(proxy->host(),QStringLiteral("127.0.0.1"));
TEST(proxy->user(),QStringLiteral("unknown_1"));
TEST(proxy->pass(),QStringLiteral("secret_1"));