diff options
author | Dirk Hohndel <dirk@hohndel.org> | 2013-12-10 06:17:15 +0100 |
---|---|---|
committer | Dirk Hohndel <dirk@hohndel.org> | 2013-12-10 06:25:30 +0100 |
commit | e5561d766852cde28ebbabf2150bab5be6183897 (patch) | |
tree | cbb019cc285b3bf09baaa5c7dc98074eaf2ffe8b /translations | |
parent | eaa31600820b95f7acc51979048e2970ac1d4821 (diff) | |
download | subsurface-e5561d766852cde28ebbabf2150bab5be6183897.tar.gz |
Fix selection tracking bug
When trying to remember a newly manually created dive across the
sort_table() call I abused the dive->selected flag and didn't clear it out
afterwards (most likely thinking "hey, I'm calling selectDive() on this
anyway").
This caused the UI code to correctly mark the dive as selected, but when
it called down to the C code to keep the internal data structures in sync,
that code didn't update amount_selected as it thought this dive had
already been selected. And that caused other parts of the code to get
confused, which manifested for example in the failed upload to
divelogs.de.
So this clears out the flag after abusing it to remember a dive. Maybe we
should add a 'remembered' flag instead, but for now this fixes the issue.
Fixes #351
Initial-fix-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Diffstat (limited to 'translations')
0 files changed, 0 insertions, 0 deletions