Fix some of the gcc-4.8 warnings

Most of the warnings are IMHO false positives:
e.g.: an enum variable is initialized in a switch statement that has a case for
      each possible enum value - yet gcc 4.8 warns that it could be used
      uninitialized;
or:   two variables are initialized together in the code - second one of them
      is previously initialized to -1 at declaration time, both are initialized
      in an if (second one == -1) clause - so they are guaranteed to both be
      initialized...
I did not "fix" those as the code is actually correct.

But there are three spots where it catches things that could indeed go wrong
(with odd input data in one of them).

This commit also adds a check to only call g_type_init() for older versions of
glib as in newer ones it is deprecated.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>

1 files changed, 3 insertions, 2 deletions

diff --git a/uemis.c b/uemis.c
index aad76c10f..3f7c71b7f 100644
--- a/uemis.c
+++ b/uemis.c
@@ -288,7 +288,7 @@ void uemis_parse_divelog_binary(char *base64, void *datap) {
 	int datalen;
 	int i;
 	uint8_t *data;
-	struct sample *sample;
+	struct sample *sample = NULL;
 	uemis_sample_t *u_sample;
 	struct dive *dive = datap;
 	struct divecomputer *dc = &dive->dc;
@@ -365,6 +365,7 @@ void uemis_parse_divelog_binary(char *base64, void *datap) {
 		i += 0x25;
 		u_sample++;
 	}
-	dive->dc.duration.seconds = sample->time.seconds - 1;
+	if (sample)
+		dive->dc.duration.seconds = sample->time.seconds - 1;
 	return;
 }