summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--core/divesite.c23
-rw-r--r--core/divesite.h2
-rw-r--r--mobile-widgets/qmlmanager.cpp4
3 files changed, 21 insertions, 8 deletions
diff --git a/core/divesite.c b/core/divesite.c
index 0ed4eb2ca..654ca45dd 100644
--- a/core/divesite.c
+++ b/core/divesite.c
@@ -171,6 +171,21 @@ struct dive_site *alloc_dive_site()
return ds;
}
+struct dive_site *alloc_dive_site_with_name(const char *name)
+{
+ struct dive_site *ds = alloc_dive_site();
+ ds->name = copy_string(name);
+ return ds;
+}
+
+struct dive_site *alloc_dive_site_with_gps(const char *name, const location_t *loc)
+{
+ struct dive_site *ds = alloc_dive_site_with_name(name);
+ ds->location = *loc;
+
+ return ds;
+}
+
/* when parsing, dive sites are identified by uuid */
struct dive_site *alloc_or_get_dive_site(uint32_t uuid, struct dive_site_table *ds_table)
{
@@ -231,8 +246,7 @@ void delete_dive_site(struct dive_site *ds, struct dive_site_table *ds_table)
/* allocate a new site and add it to the table */
struct dive_site *create_dive_site(const char *name, struct dive_site_table *ds_table)
{
- struct dive_site *ds = alloc_dive_site();
- ds->name = copy_string(name);
+ struct dive_site *ds = alloc_dive_site_with_name(name);
add_dive_site_to_table(ds, ds_table);
return ds;
}
@@ -240,11 +254,8 @@ struct dive_site *create_dive_site(const char *name, struct dive_site_table *ds_
/* same as before, but with GPS data */
struct dive_site *create_dive_site_with_gps(const char *name, const location_t *loc, struct dive_site_table *ds_table)
{
- struct dive_site *ds = alloc_dive_site();
- ds->name = copy_string(name);
- ds->location = *loc;
+ struct dive_site *ds = alloc_dive_site_with_gps(name, loc);
add_dive_site_to_table(ds, ds_table);
-
return ds;
}
diff --git a/core/divesite.h b/core/divesite.h
index 30daf3bea..022d2c0fe 100644
--- a/core/divesite.h
+++ b/core/divesite.h
@@ -52,6 +52,8 @@ void sort_dive_site_table(struct dive_site_table *ds_table);
int add_dive_site_to_table(struct dive_site *ds, struct dive_site_table *ds_table);
struct dive_site *alloc_or_get_dive_site(uint32_t uuid, struct dive_site_table *ds_table);
struct dive_site *alloc_dive_site();
+struct dive_site *alloc_dive_site_with_name(const char *name);
+struct dive_site *alloc_dive_site_with_gps(const char *name, const location_t *loc);
int nr_of_dives_at_dive_site(struct dive_site *ds);
bool is_dive_site_selected(struct dive_site *ds);
void free_dive_site(struct dive_site *ds);
diff --git a/mobile-widgets/qmlmanager.cpp b/mobile-widgets/qmlmanager.cpp
index 939ec51bf..dd0a37282 100644
--- a/mobile-widgets/qmlmanager.cpp
+++ b/mobile-widgets/qmlmanager.cpp
@@ -922,7 +922,7 @@ static void setupDivesite(DiveSiteChange &res, struct dive *d, struct dive_site
res.editDs = ds;
res.location = location;
} else {
- res.createdDs.reset(create_dive_site_with_gps(locationtext, &location, &dive_site_table));
+ res.createdDs.reset(alloc_dive_site_with_name(locationtext));
add_dive_to_dive_site(d, res.createdDs.get());
}
res.changed = true;
@@ -1040,7 +1040,7 @@ bool QMLManager::checkLocation(DiveSiteChange &res, const DiveObjectHelper &myDi
if (myDive.location != location) {
ds = get_dive_site_by_name(qPrintable(location), &dive_site_table);
if (!ds && !location.isEmpty()) {
- res.createdDs.reset(create_dive_site(qPrintable(location), &dive_site_table));
+ res.createdDs.reset(alloc_dive_site_with_name(qPrintable(location)));
res.changed = true;
ds = res.createdDs.get();
}