summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2016-01-22build.sh: fix logic when to build grantleeGravatar Dirk Hohndel
Grmbl. SUBSURFACE_EXECUTABLE now doesn't get set until later in the script. So let's just trigger this explicitly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22configure OSTC/OSTC3: Add safety stop parametersGravatar Anton Lundin
This adds the configure parameters for safety stops on the hwOS(OSTC3) and OSTC computers. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22configure OSTC3: Add temperature sensor offsetGravatar Anton Lundin
Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22Use libdivecomputer libc wrappers instead of QtGravatar Anton Lundin
Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22Remove unused headersGravatar Anton Lundin
Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22Remove workaround for OSTC Sport 10.22 and belowGravatar Anton Lundin
Now with firmware 10.23, the settings behave as they should, and won't hang the communication. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22QML-UI. Improved button styleGravatar Jan Mulder
Pressing of buttons were difficult to see mainly due to small buttons and small color distance between pressed and un-pressed state. This fix enlarges the buttons a little, and choses a different color for the pressed state. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22QML-UI. Add Back to Divelist menu itemGravatar Jan Mulder
As asked for on the mailinglisrt, a menu item is added to return to the Divelist the easy way. In addition to the standard Android back button. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-22Avoid precision loss on GPS fixesGravatar Dirk Hohndel
It appears that the Qt documentation might be incorrect. It claims that the precision value is digits after the decimal point, but we have seen examples where the values posted to the server appear to have a total of 6 digits, including the digits ahead of the decimal point. Upping this to 9 shouldn't hurt if Qt gets fixed, but should work around the issue reported by a tester. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-21QML UI: maximize horizontal size of notes when editingGravatar Dirk Hohndel
This seems a bit brute force but I couldn't get the width to propagate correctly any other way. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-21QML UI: show dive trip againGravatar Dirk Hohndel
This once again displays trips in the dive list and makes the visual a bit more spaceous. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-21Return a value when getting SAC rateGravatar Dirk Hohndel
Obvious "mass edit" error. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-21QML UI: fix map display regressionGravatar Dirk Hohndel
In commit 6540e95425eb ("dive details navigation") the change to access the gps variable was only partially implemented. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-20QML UI: switch edit back to not being a drawerGravatar Dirk Hohndel
With this edit seems to work again. The edit page can be scrolled around on smaller screens to allow editing every part of it and to allow the user to press the "save" button. This is mainly intended to make sure testing can continue - it's unclear if this will be the final design. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-20QML UI: show date and time for diveGravatar Dirk Hohndel
We keep losing the time when people move code around. date really is just the date and doesn't include the time component. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-20QML UI: fix bugs in change detection on dive editGravatar Dirk Hohndel
We were comparing apples to oranges on a few items and therefore more or less always assumed that a dive had been modified. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-20If set imperial units explicitly on mobile appGravatar Miika Turkia
If unit_system is set to imperial, we need to set the units explicitly on mobile application. Fixes #993 Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-20QML preferences: use Layout.preferredHeight within GridLayoutGravatar Rick Walsh
It's not recommended to set the height explicitly of an item in a layout. Use Layout.preferredHeight instead Signed-off-by: Rick Walsh <rickmwalsh@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-20QML UI: make all buttons more attractiveGravatar Rick Walsh
Commit f3f7930 introduced a more attractive button style to the start page. This patch turns it into its own type so it can easily be used everywhere. Signed-off-by: Rick Walsh <rickmwalsh@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19QML UI: make the buttons on the start page more attractiveGravatar Dirk Hohndel
Those plain rectangular buttons were just too ugly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19Fix UI issue with location managementGravatar krisalpha
The index in the fixpopup function was incorrect which caused the user to need TWO cursor down presses to move to the second element. I changed the index value so the user now needs only one key press to traverse up/dowm. Fixes #954 Signed-off-by: krishan Chopra <choprakrishan61@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19QML UI: Don't explicitly set width of GridLayout itemsGravatar Rick Walsh
It is not recommended to set the width explicitly of items in a layout. This caused some issues in DiveDetailsView, which were fixed by commit 1030cb2. See http://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#details Set 'Layout.preferredWidth' instead of 'width' for GpsList and Preferences Signed-off-by: Rick Walsh <rickmwalsh@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19QML UI: don't shorten the buttonsGravatar Dirk Hohndel
I want a prettier visual for those, anyway, but artificially making them shorter than that text they display seems silly - and causes the text to be trunkated for no good reason on some devices. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19Subsurface-mobile on Android: change the splash screen methodologyGravatar Dirk Hohndel
This is based on post by Ben Laud https://medium.com/@benlaud/complete-guide-to-make-a-splash-screen-for-your-qml-android-application-567ca3bc70af It creates a theme that uses a splash drawable that Android will show immediately when the application is launched. And then starts the QML application with visibility set to false adn only makes it visible (and replace the splash screen) once initialization is finished. We still get a little flicker with the switch from splash to start page to dive list, but over all the experience is hugely improved. And the bug that the splash screen stays around when starting Subsurface-mobile in landscape also appears to be fixed. Fixes #994 Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19Don't blindly copy a pointer to the heapGravatar Dirk Hohndel
Copying the entry pointer and assuming that it stays valid is of course totally bogus. This is most likely the reason for the random crashes people have observed. See #992 Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-19Close edit drawer when current dive changesGravatar Sebastian Kügler
This prevents having the edit drawer opened at a different than the current dive. Signed-off-by: Sebastian Kügler <sebas@kde.org>
2016-01-19QML UI DiveDetailsView: shift dive number to right of top rowGravatar Rick Walsh
In dive details view, shifting the dive number to the right of the top row means it won't be cut short if the dive duration is 1 hr or longer Signed-off-by: Rick Walsh <rickmwalsh@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-18QML UI: yet another attempt to fix the profile scalingGravatar Dirk Hohndel
This one appears to work in my testing so far. And reading the code it seems to make sense. We look at the size that the widget thinks it is. And we scale the scene to fill that size (including a margin). And then let Qt and QML deal with the rest of it. Assuming this works it shows that we have been trying too hard all this time. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-18Fix crash with empty (or very short) dive listGravatar Dirk Hohndel
In commit 37c10c8fd6 ("Add dive type to statistics window") not enough space is reserved for the newly introduced array if the dive list as fewer than 4 entries. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-18build.sh: fix broken logic to pull mobile componentsGravatar Dirk Hohndel
In commit f28f03afe2 ("build.sh: make it easier to build Subsurface-mobile") I mistakenly broke the logic that decides to run the mobilecomponents.sh script. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-18Add dive type to statistics windowGravatar Miika Turkia
This adds dive type based division to the "yearly statistics" window. Thus people can see the stats from individually from OC, CCR, PSCR and freedive. See #949 Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-17Hide the time from trip tabGravatar Miika Turkia
This hides the start time when viewing trip details. See #964 Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-17Mark date field readonly on trip editGravatar Miika Turkia
The date comes from the first dive in trip, thus no need to allow editing (especially since the edited date seems to be discarded in any case). Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-17build.sh: make it easier to build Subsurface-mobileGravatar Dirk Hohndel
The script now takes a -mobile argument, or -both and then builds the mobile version or both versions. To make things more consistent across different invocations the desktop version is built in the "build" directory and the mobile version is built in "build-mobile". Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-17Make default build for desktop.Gravatar Willem Ferguson
Make the default build a DesktopExecutable, with an option to set a variable for doing a mobile build. Signed-off-by: Willem Ferguson <willemferguson@zoology.up.ac.za> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15QML UI: next attempt to address the profile scalingGravatar Dirk Hohndel
It seems to be much more logical to address the size and scale right before rendering. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: implement the unit settingsGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: unit systemGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: dive planner preferencesGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: add PlannerSettingsGravatar Tomaz Canabrava
We probably want to change that on the prefs struct too. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: cloud storage preferencesGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: finish network preferencesGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: start Proxy QObject configGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: some cleanupsGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: geocoding preferencesGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: minor cleanupsGravatar Tomaz Canabrava
Rename a few methods wrongly named and place them on the correct place on the file. Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-15Settings QObjectification: Facebook settingsGravatar Tomaz Canabrava
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-13Don't round up / use minimum duration for profile in Subsurface-mobileGravatar Dirk Hohndel
On the desktop we have long had this vision of a minimum length and a "pleasant" duration of the profile - but on a device this seems to look like uneven margins. So let's just add space for the labels and not otherwise mess with the duration. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-13try to fix profile scalingGravatar Sebastian Kügler
Different approach here: - profile gets a bit higher, this was requested on the mailinglist, and seems to behave much better with the painted profile, we'd otherwise get it magically clipped on the right hand side. - Make the scaling dpi aware, this fixes scaling for me on the Nexus7, I haven't been able to test it properly on other devices, so this needs some more testing. The result is visually quite close to what we can do, although I'm still getting a somewhat larger margin on the right. To get at the devicePixelRatio without too much custom code, I've added a property to the QMLProfile to retrieve it from the theme engine. Signed-off-by: Sebastian Kügler <sebas@kde.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-01-13fix misrendered profiles when fast-flickingGravatar Sebastian Kügler
- Apparently, QMLProfile doesn't like being painted without being visible, when flicking quickly through the dives I would get empty rendered profiles. Setting the cachebuffer to zero fixes it, and saves some memory. It still has some unfortunate timing, the profile gets rendered mid-flick, which leads to a delay in the flicking motion, quite annoying. We will have to somehow make sure that new profiles are rendered after flicking, not during - Smallish cleanups Signed-off-by: Sebastian Kügler <sebas@kde.org>