summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2017-10-27QML UI: repair long trip headersGravatar Jan Mulder
Trip headers spanning more than one line where broken at incorrect locations in the string. Not exactly sure, but I think this came with the newest Kirigami SHA, and especially the Label change. Carefully reading the code for the trip heading shows a "strange" negative margin. So the margin is on the outside. This margin was used to split the string, allowing for a small invisible part of the string to present as trip header. This is solved by this commit. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2017-10-26Clear error string when starting dive computer dowload.Gravatar Berthold Stoeger
Fixes minor interface inconsistency: After a failed download, the error message was also shown on subsequent successful downloads. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2017-10-26git save: create a better commit message for initial commitGravatar Dirk Hohndel
When we create an empty repo we should simply state that in the commit message. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26git save: don't save the git_id if just creating empty repoGravatar Dirk Hohndel
Otherwise the following call to do_git_save will potentially have incorrect information about the cache validity of the dives in the divelist. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26git save: remove redundant 'subsurface' from commit messageGravatar Dirk Hohndel
The user agent string already contains the (correctly capitalized) program name. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Report which files were opened / imported at startGravatar Dirk Hohndel
We only do this in verbose mode to make sure a report contains the information about the existing files used. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26git storage: print the actual errorGravatar Dirk Hohndel
It seems silly to not show what git told us went wrong. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26cloudstorage: handle invalid PIN correctlyGravatar Dirk Hohndel
If the server tells us that the PIN is invalid, we need to continue to ask for a PIN. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26cloudstorage: better member name when updating authentication stateGravatar Dirk Hohndel
This isn't just about showing the PIN or not. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Remove bogus member that hides global variableGravatar Dirk Hohndel
Inexplicably, commit 8b7427c56d ("Move CloudStorage out of the widgets") didn't just move the code but added a local member 'verbose' that hides our global variable... Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Support for trimix on jdivelog importGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2017-10-26Merge pull request #726 from Subsurface-divelog/rewriteErrorHandlingGravatar Tomaz Canabrava
Rewrite error handling
2017-10-26Desktop UI: notify user if they need to enter a cloud PINGravatar Dirk Hohndel
This will need to be merged / cleaned up once the git storage fixes have been merged. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26desktop UI: no longer attempt to manually show error notificationsGravatar Dirk Hohndel
report_error() now does this automatically. So all these odd places in which we tried to make sure that we show errors are no longer needed. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Divelistview: use report_error to report and errorGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Don't show error if cloud credentials aren't set upGravatar Dirk Hohndel
This became rather obvious with the change to immediately show errors. The commit also fixes a small memory leak. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26desktop UI: always show errors when reportedGravatar Dirk Hohndel
Instead of waiting for a manual call to showError(), simply use the new callback to always immediately show the error in the notification widget. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Set error callback helperGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-26Move error reporting into its own source fileGravatar Dirk Hohndel
This doesn't really seem to belong in save_git.c. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-25Update the rendered version of Spanish Subsurface-mobile manualGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-23Respect autogroup in Subsurface-mobileGravatar Dirk Hohndel
After we download new dives we need to try to autogroup them. In Subsurface this is done when we refresh the dive list. Here we might be better off doing it right after processing the new dives. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-23Mac build: update instructionsGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-23Mac build: use more system librariesGravatar Dirk Hohndel
libxml2, libxslt, and libsqlite3 are new enough on macOS to no longer require our own versions. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-23Mac build: don't force link against OpenSSLGravatar Dirk Hohndel
libgit2 uses native SSL / crypto on Darwin/macOS. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-23Make the map widget more pleasant to useGravatar Linus Torvalds
This does two main things to the map widget: - if there are no coordinates, do *not* zoom out to the whole-world view. Just leave the map alone. - when zooming out to move to a new dive site, zoom back in to the same zoom level it was before. These two changes make it much more pleasant to move between dives, particularly as you move back-and-forth without losing the zoom level. NOTE! The zoom level gets reset if you move dives _while_ zooming is happening, and so moving quickly between dives will still end up losing the original zoom level, replacing it with a bigger zoom-out that was active _during_ a previous zoom. That could be seen as a feature (moving incrementally to an "overview" zoom when moving quickly between dive sites), but honestly it smells more like a bug to me. But regardless of that feature/bug, this new zoom behavior is more pleasant than our older "always reset when moving". But it might be a matter of taste, so people should try this out and comment. Signed-off-by: Linus Torvalds <torvalds@linux-foundation,org> Cc: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-23Fix broken multi selected dive to tripGravatar Jan Mulder
See referenced issue number. It leads back to an ancient (3 year old) commit 512c42e. Not sure this issue is introduced there, but that's not relevant. Key in reproducing this is the location where the context menu is requested (using the right mouse button). When it is the row next to the trip, the add-to-trip succeeds correctly, otherwise it is a no-op. The solution is rather trivial (in hindsight). Just loop over the selected dives, and try to find the trip we want to add to. Fixes: #522 Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2017-10-23[Facebook] Back to previous behavior when we were able to upload data,Gravatar Guillaume GARDET
even without album creation permission
2017-10-23[Facebook] add more debug when we are not able to create a new albumGravatar Guillaume GARDET
2017-10-23Remove unused iconsGravatar Dirk Hohndel
When trying to trace down an unrelated issue with flag icons, I realized that these two are no longer used. They were part of our Marble setup. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-22Include qml-module-qtquick2Gravatar Miika Turkia
Ubuntu and Debian require package qml-module-qtquick2 to be installed. Fixes #720 Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2017-10-22Update internal version numbersGravatar Dirk Hohndel
Dang, this one should have gone into 4.7.1. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-22Release notes for planner addedGravatar Robert C. Helling
Signed-off-by: Robert C. Helling <helling@atdotde.de>
2017-10-22Another small German translation updatev4.7.1Gravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-22mainwindow: disable fullscreen support by defaultGravatar Lubomir I. Ivanov
Require the FULLSCREEN_SUPPORT macro to enable fullscreen support. The toggle was added 4 years ago in Subsurface, but with the current version of Qt 5.9.x, it's very buggy on Windows and Ubuntu. While it's possible to make this work on Windows, it seems to behave broken in different ways on different versiosn of Ubuntu. Fixes #705 Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
2017-10-21Latest German translationsGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-21When removing a cylinder completely fill the mapping tableGravatar Stefan Fuchs
When deleting a cylinder the mapping was not filled with all necessary values. Values for cylinders before deleted cylinder were missing. Plus do the endRemoveRows at the right time. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2017-10-21user-manual: 1 letter typoGravatar Jan Mulder
dice -> dive Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2017-10-21user manual: re-correct pSCR wordingGravatar Jan Mulder
Unsure where and why this got changed in the update to 4.7. In pSCR world, the gas that is currently driving the rebreater is called a "driving gas". This is not per definition backgas, as any gas can be plugged in by means of a swichblock. Further. The gas that is trown away (typically 10%) is released from the unit at inhale of the diver. Yes, this may sound weird to the average OC diver, but it is like that. It's by design. All this wisdom from a GUE trained RB80 diver :-) Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2017-10-21Mention green tank change icon for EAN100 in ReleaseNotesv4.7.0Gravatar Dirk Hohndel
This is my shout out to Stefan for his awesome contributions this year! Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-21Release notes V4.7 - items from sfuchs79Gravatar Stefan Fuchs
Adding my items for the release notes. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2017-10-21Try to be consistent with American spellingGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-21User manual spelling errorsGravatar Willem Ferguson
I finaly got a a spelling checker that operates on asciidoc files. I am relieved that this only found about a dozen spelling errors in the whole text. Signed-off-by: Willem Ferguson <willemferguson@zoology.up.ac.za> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-21Small edits to user manual V4.7Gravatar Willem Ferguson
Small edits, typos and responses to comments of other developers. One image replaced. Signed-off-by: Willem Ferguson <willemferguson@zoology.up.ac.za> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-21Documentation: Merge and update french translationsGravatar Guillaume GARDET
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-21user manuals: EN and NL, changed for Subsurface-mobileGravatar Jan Mulder
Small set of changes to both the NL and EN user manuals. 1) Corrected screendumps of the mobile app to version 2 of the app. 2) Corrected the removed checkbox in the main menu to a normal menu item in the GPS menu for the location service. So, nothing more than some maintenance. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2017-10-20Update README for 4.7Gravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-20Remove last hints of MarbleGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-20Updates to Catalan translationGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-20Silence random warningsGravatar Dirk Hohndel
None of these seem to point to actual issues, so let's quiet them. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-10-20cmake: deal with occasional build order issueGravatar Dirk Hohndel
I only ran into this a couple of times and can't figure out why it picked the order in which it tried to build things - but hard coding the dependency seems to have fixed it (then again, since I didn't always run into this, I'm not sure). Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2025-01-06 21:41:16 +0000