summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2015-09-12Add importing of working pressure from divelogs.deGravatar Miika Turkia
We were missing the import of cylinders' working pressure when syncing with divelogs.de. This piece of information is required for proper unit conversions when user uses imperial units for displaying the dive information. (Both Subsurface and divelogs.de use metric internally, or at least the export from divelogs.de is in metric.) See #907 Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-12Hide current dive site from dive sites with same coordinates.Gravatar Sander Kleijwegt
Signed-off-by: Sander Kleijwegt <sander@myowndomain.nl> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-12Remove id from divelocation selection listGravatar Sander Kleijwegt
Signed-off-by: Sander Kleijwegt <sander@myowndomain.nl> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-12Update spanish translation of user-manual to english 0dd32d3Gravatar Salvador Cuñat
Easy access to cloud storage. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-12Update spanish translation of user manual to english e4c0f3fGravatar Salvador Cuñat
- Dive sites - Printing - APD CCR - Sections reorder - Images update Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-12VPM-B: Calculate ceiling in deepest portion of diveGravatar Rick Walsh
The Boyle's law compensation compares the ambient pressure to a baseline value, and adjusts the theory bubble radius accordingly. Currently we use the ceiling at the last user-entered waypoint (the start of the decompression phase) as the baseline value. However, in a deep to shallow multi-level dive, decompression can start earlier, and taking a shallower ceiling leads to a more aggressive ascent. This is particularly noticeable if the user enters stops during ascent. With this commit, we take the baseline ambient pressure for Boyle's law compensation as the deeper of the: (1) Ceiling prior to ascending during a user-entered portion of the dive, and (2) Ceiling at the start of the last user-entered waypoint. This makes the calculated profile more conservative for some deep to shallow multi-level dives. Signed-off-by: Rick Walsh <rickmwalsh@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-11CSV import: strip whitespace from column names before matchingGravatar Dirk Hohndel
In a user provided sample the last column name included "\r\n" which prevented us from automatically matching that column. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-11When editing a manually added dive, correctly update max depthGravatar Dirk Hohndel
The fixup_dive() function assumes that values that are set already in the divecomputer and dive structures come from a reliable source - sometimes dive computers are able to track a maximum depth continuously, so that value can be larger than the deepest sample and we need to honor that. But in the case of a manually added dive, the samples define the dive. So in this case we need to reset the values that were calculated when the dive was first added so that the user can then edit the dive and reduce the maximum depth reached in the profile and have that reflected in the dive list. Fixes #926 Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-11Uemis downloader: code optimizationGravatar glerch
Cleaned up the code in do_uemis_import, this way it should run a little faster as I am doing the check if the returned divespot is valid at an earlier point Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-11Uemis downloader: cleaning up debug bitsGravatar glerch
At some point I would like to understand the logic behind the debug bits, so I am not messing around with them. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-11Add checkbox to force images to match divesGravatar Robert C. Helling
Give the user the possibility to attach images to a dive even when the times do not match Signed-off-by: Robert C. Helling <helling@atdotde.de> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-11Don't offer gas selection for the last waypoint in plannerGravatar Robert C. Helling
Since the gas selection list on a waypoint refers to a gaschange there influencing the following segments, there must not be a gas selection on the last manually entered waypoint since from there the planner handles the gas selection. Signed-off-by: Robert C. Helling <helling@atdotde.de> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Configure divecomputers: remove unused memberGravatar Anton Lundin
Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Configure divecomputers: add delegates for setpoint configurationGravatar Anton Lundin
This adds delegates to simplify configuration of setpoint values in the OSTC's. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Configure divecomputers: access table data the same way as its setGravatar Anton Lundin
The table data is set via role, so retrieve the data via role too. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Configure divecomputers: fix spelling of FirstGravatar Anton Lundin
Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Be compatible with libgit2 0.22 againGravatar Anton Lundin
The callback function was introduced in 0.23, so put it behind that ifdef. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Get ready for OS X 10.11 El CapitanGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: bug fix in uemis set dive locationGravatar glerch
Assuring that ds isn't NULL, had a few cases that made SubSurface crash. Have not investigated the root cause but it's likely that it is related to the Uemis specific code. Nevertheless, checking ds non NULL is certainly not a bad thing to do. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: remove memory leaksGravatar glerch
Found more memory leaks Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: assure empty divespots are not addedGravatar glerch
If the load_uemis_divespot returns false we must assure we delete the divespot that was created during process_raw_buffer Also added some comments Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: remove code not needed anymoreGravatar glerch
Cleaning up track_uemis_divespot because this function is not needed anymore. As I am loading the divespots now within do_uemis_import, I also adjusted the memory calculation - this is not completed yet. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: new logic for divespotsGravatar glerch
Changed the do_uemis_import to load divespots right after matching the dive details. Logic implemented to verify that we are not duplicating divespots by comparing the uuid from get_dive_site_by_uuid(dive->dive_site_uuid) with the one from get_dive_site_uuid_by_name Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: deleting code because of design changeGravatar glerch
Deleting unnecessary code to support future design change coming with the next patch Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: new routine to load divespotsGravatar glerch
Added load_uemis_divespot. This will be used later in do_uemis_import to improve the amount of divespots that must be loaded actually. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: new find divespot by diveidGravatar glerch
New routine to support finding a dive spot based on the dive id, this is needed due to the weird way Uemis is providing data. This function will be used in the uemis-downloader.c within do_uemis_import. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: fix bug when creating dive siteGravatar glerch
Use dive->when when creating a dive site instead of time(NULL) as Dirk suggested Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Document simplified web access to cloud storage dataGravatar Dirk Hohndel
The backend now redirects you to the correct URL once you log in with your email address and password. So all the user needs to know is to go to https://cloud.subsurface-divelog.org Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Cloud storage: add another progress callbackGravatar Dirk Hohndel
This one sadly only appears to be called with 0% and 100% in my examples. Not sure what to do about that. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Save settings in closeEvent, not destructorGravatar Anton Lundin
This switches to use the closeEvent to save settings and cleanup instead of the destructor. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix another memory leak on uemis downloaderGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix memory leak on uemis downloaderGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Initialize variable before useGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix memory leaks in serial ftdiGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix memory leak on serial bluetoothGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Datatrak parsingGravatar Miika Turkia
I have some trouble understanding this code, but as there is a clear bug involved (null dereference), I ask others to verify if I am onto something. And if datatrak import still works with this patch. From af2935622b1f00f373ed38c8e3194e25504372b6 Mon Sep 17 00:00:00 2001 From: Miika Turkia <miika.turkia@gmail.com> Date: Wed, 9 Sep 2015 18:03:45 +0300 Subject: [PATCH] Fix null dereference and parsing logic Null dereference in the first change is obviously a bug. The parsing logic I only assume to be wrong and suggest that we discard dives that are deemed to be bogus. Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Whitespace cleanupGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09OSTCTools - remove useless pointer ldc_datGravatar Salvador Cuñat
This device_data_t pointer was a remnant from initial work. It is useless and can be safely removed. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09ReleaseNotes: update changes towards Beta 2Gravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Documentation: update french translation of user-manualGravatar Guillaume GARDET
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Exit with failure if the first dc_open method failsGravatar Claudiu Olteanu
If the dc_serial_*_open method fails then we should exit with an error and don't try to open the device using the native implementation. Signed-off-by: Claudiu Olteanu <olteanu.claudiu@ymail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Do not ignore the first tag on autocompletion.Gravatar Sander Kleijwegt
Signed-off-by: Sander Kleijwegt <sander@myowndomain.nl> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Replace the spinner with a progress dialog for cloud storage accessGravatar Dirk Hohndel
Since the spinner caused all kinds of problems inside VMs, wasn't shown at all for some people on Win10 and appeared to get stuck a lot and still left people with the perception that Subsurface was hung, this patch takes a more traditional approach and gives the user a progress dialog. An additional benefit of this is that the user now can cancel a hung transfer. The slightly weird passing in of the callback allows for the separation of UI and core logic code... Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09qthelper.cpp: don't hardcode the Dive m_duration as minutesGravatar Lubomir I. Ivanov
get_dive_duration_string() should be used in a similiar way to socialnetworks.cpp so that the Dive::put_duration() method sets the variable in the h:min format. Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09qthelper.cpp: use timeFormat and dateFormat for the Dive classGravatar Lubomir I. Ivanov
The Dive class has a method which sets the m_time and m_date members but it uses a custom format. By using the static dateFormat and timeFormat variables this helper class now uses the same date and time format as in the dive list. Fixes #920 Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Delay freeing of memory after useGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix a crash on divelogs.de exportGravatar Miika Turkia
Subsurface crashes when multiple dives are selected on divelogs.de export. The crash occurs on malloc that is called indirectly from xmlReadMemory(). Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Translation updatesGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Two small string changesGravatar Dirk Hohndel
Reported by Ettore Atalan on Trnasifex. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Only use DC_TRANSPORT_* with SSRF_CUSTOM_SERIALGravatar Anton Lundin
This if'defs DC_TRANSPORT_* use with SSRF_CUSTOM_SERIAL, because the enum doesn't exist when building against stock libdivecomputer. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2025-01-06 21:36:09 +0000