summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2019-12-28mobile-widgets/qml: correct missing parm in saveCredentials() callGravatar jan Iversen
Add missing empty pin ("") in saveCredentials() call. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: prefs.credentialStatus -> PrefCloudStorageGravatar jan Iversen
Remove use of prefs. (apart from instanciating the object) in main.qml Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: "Add dive manually" is always allowedGravatar jan Iversen
Since the divelist is only visible if online/offline (CS_VERIFIED/CS_NOCLOUD), there is no need to check that to enable "Add dive manually". Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: don't offer manual sync to cloud in no-cloud modeGravatar jan Iversen
Manual sync was enabled both for CS_VERIFIED (online) and CS_NOCLOUD (offline) and then in the trigger CS_NOCLOUD lead to a login screen, potentially confusing the user. Only enable manual sync with verified cloud credentials. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: remove use of prefs. in DiveList.qmlGravatar jan Iversen
prefs. is only important during the signin process, so use the standard PrefCloudStorage variable Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets: remove cloudPin from qmlprefsGravatar jan Iversen
cloudPin is no longer used, remove it. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets: remove cloudPin() from qmlmanagerGravatar jan Iversen
cloudPin does only have the values "" and NULL, so replace cloudPin() with "" in csa->backend() call remove setting of cloudPin to "" Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widget: simplify saveCredentials() in qmlmanagerGravatar jan Iversen
cloudPin is only set to "" and NULL, therefore and "if" checking if cloudPin is not empty will never have affect. Remove else part. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets: make verifyCredentials() an internal functionGravatar jan Iversen
Move verifyCredentials() from public slots to private, eliminating the need to MOC and making the C++/QML interface on function less complicated. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets: make saveCredentials() an atomGravatar jan Iversen
Add pin parameter to saveCredentials() thereby having all info about credentials in one function call. Add "" as pin in saveCredentials() - main.qml, when verifying credentials. replace verifyCredentials() with saveCredentials() in the register button on the pin page. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets: remove clearCredentials()Gravatar jan Iversen
clearCredentials() was only called from one place (in the same file), copy functionality and remove function. It was declared as a public slot, so this saves a little bit of overhead too. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets: remove cancelCredentialsPinSetup() from qmlprefsGravatar jan Iversen
cancelCredentialsPinSetup() is no longer used, so remove it. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: don't call cancelCredentialsPinSetup()Gravatar jan Iversen
Copy functionality from cancelCredentialsPinSetup() into Cancel in CloudCredentials.qml, this is part of the general qmlprefs cleanup. Remove rootItem.returnTopPage() since the user stays on this page (sees credentials again). Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: remove cancelCredentialsPinSetup() from SettingsGravatar jan Iversen
For now just copy the functionality into Settings.qml, this is part of the qmlprefs cleanup. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: correct reference to credentialStatusGravatar jan Iversen
PrefCloudStorage uses cloud_verification_status where qmlprefs uses credentialStatus Corrected reference. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-28mobile-widgets/qml: remove property credentialStatusGravatar jan Iversen
Property is unused, remove it. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29tests: add gas tests for plannerSharedGravatar jan Iversen
Add cases to test gas options. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-29tests: add research values for diveplanning.Gravatar jan Iversen
This commit contains the researched values used for diveplanning, which form the basis for the test cases. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-29Update CHANGELOGGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile UI: add menu item for cloud password resetGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile UI: restructure help/support menuGravatar Dirk Hohndel
Instead of having two entries on the main menu, move them into a sub menu. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile: small whitespace cleanupGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile UI: add support and account iconsGravatar Dirk Hohndel
These were again copied from the material design icon set and will be used to differentiate the various help topics. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile UI: add back button to planner menuGravatar Dirk Hohndel
Otherwise you are stuck in there. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile UI: remove confusing gDrawer idGravatar Dirk Hohndel
The global drawer already has a name that can be referenced. This was adding confusion as now both names were used in the menu structure. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-29mobile-widgets/qml: add "forgot password" buttonGravatar jan Iversen
The user is most likely to find out, that he does not remember the password, when asked for it. Add "forgot password" button in the signin dialog (both credentials and pin dialog). Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-28mobile-widgets: correct faulty connect.Gravatar jan Iversen
1) add comment line (signal to signal) 2) correct spelling error in comment 3) correct connect Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-28planner: correct rating calculations.Gravatar jan Iversen
Test show that the ratings calculations were off by +/- 1, due to rounding errors. Found due to test cases in tests (other commits) The calculations are copied 1-1 from diveplanner.cpp, but are used slightly different in plannerShared.cpp Correct calculations, by securing the calculation is done with float precision and the rounded with lrint(). Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-28mobile-widgets/qml: correct first view of divelistGravatar jan Iversen
pageStack.initPage cannot be used as a function and causes an error Replace with showDiveList() Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-28mobile-widget/qml: avoid binding loop in GlobalDrawerGravatar jan Iversen
rightPadding seems defined in Kirigami and the default value causes a binding loop. set rightPadding directly. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27Cosmetic updates to .UI files for PreferencesGravatar willemferguson
This is a cosmetic update to remove some warning messages while building a fresh subsurface. These warnings were due to duplicate label names in the .UI files. Signed-off-by: willemferguson <willemferguson@zoology.up.ac.za>
2019-12-27tests: add test cases plannerShared ratingsGravatar jan Iversen
Add test cases to test ratings variables Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27tests: activate TestPlannerSharedGravatar jan Iversen
Use updated CMakeLists to activate TestPlannerShared but only for mobile builds !! This is due to the fact that commands are currently not available for mobile builds. Using the mobile library version of qt-mobile secured diveplannermodel.cpp is compiled without referencces to commands. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27tests: add framework for plannerShared testGravatar jan Iversen
Add TestPlannerShared test (cpp + h) Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27buildsystem: update tests to include more librariesGravatar jan Iversen
In order to test plannerShared (backend-shared) more libraries are needed. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27testing: prepare diveplannermodel to be used in testingGravatar jan Iversen
In order to make tests for plannerShared, some qt-models must be linked, and due to the fact that commands are currently not available for mobile (which also makes the tests) and #ifdef must be added. The test version of diveplannermodel will be specially compiled in (SUBSURFACE_TESTING set) in the tests directory. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27core/settings: make qPrefUnit accesable from QMLGravatar jan Iversen
Use string literals to communicate with QML. Instead of passing arounds enum/int value, it seems easier to pass string literals to QML and have that code respond to those Signed-off-by: Jan Iversen <jani@apache.org>
2019-12-27core: use set_lang_locale to modify prefs.locale.lang_localeGravatar jan Iversen
Do not set prefs.locale_lang_locale directly, but do it indirectly through qPrefLanguage::set_lang_locale(), to ensure the file plist is consistent with prefs. the difference (prefs. contra plist) cause surprises when restarting mobile (and playing with language). Signed-off-by: Jan Iversen <jani@apache.org>
2019-12-27documentation: updated text for testing.Gravatar jan Iversen
Update text to reflect how the build works now Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-27documentation: change filename to follow standardGravatar jan Iversen
change Readme.testing --> README_TESTING.md and thereby not contain a mixture of upper/lower case letters. Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26documentation: coding style, existing file namesGravatar jan Iversen
Existing file names should not be changed without a reason. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-26documentation: coding style cpp/h namesGravatar jan Iversen
Add rule about cpp/h names [Dirk Hohndel: small edits to the rule] Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-26documentation: coding style.Gravatar jan Iversen
CodingStyle.md should not be the first file, not the adhere to the styles. Rename CodingStyle.md --> CODINGSTYLE.md to follow the standard of other documents. Signed-off-by: Jan Iversen <jan@casacondor.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2019-12-26documentation: add changed login to CHANGELOG.mdGravatar jan Iversen
Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26mobile-widgets: remove envelope of saveCredentialsGravatar jan Iversen
Remove QML saveCredentials since it only calls manager.saveCredentials Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26mobile-widgets/qml: correct Pin pageGravatar jan Iversen
Did not switch to divelog page. call verifyCredentials() not saveCredentials when checking pin Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26mobile-widgets: correct switch to no-cloud mode.Gravatar jan Iversen
saveCredentials() missed parameters Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26mobile-widgets/qml: diveplannersetup graphical layoutGravatar jan Iversen
Add graphical layout to setup page Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26documentation: add line in CHANGELOG.mdGravatar jan Iversen
Signed-off-by: Jan Iversen <jan@casacondor.com>
2019-12-26mobile-widgets/qml: add diveplanner pages to globalDrawerGravatar jan Iversen
Add "Dive planner" menu entry in GlobalDrawer/Developer with 4 subitems one for each diveplanner pages. Developer is chosen in order to allow interested access to pages, without raising expectations for the normal user. That allow a step-by-step implementation Signed-off-by: Jan Iversen <jan@casacondor.com>
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2024-12-30 22:18:28 +0000