| Age | Commit message (Collapse) | Author |
|---|
|
When removing dives, the UndoCommands would keep track of the
shown dives. When adding, they were calling into the filter
instead. Let's remove this asymmetry.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
The shown_dives variable was reset by the dive_list code. Arguably,
the filter should keep track of the number of shown dives, so move
the resetting there. This means adding a new "reset()" member function
to the filter and call that instead of "updateAll()" when the core
data is reset.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
This appears to be needed only for Android with Qt 5.15. Which means
that this commit creates odd breakage in case someone were to try to
build for Android with an older Qt version - but given that the current
build process only works with Qt 5.14 or 5.15, I think this is an
acceptable flaw.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Can't believe I missed that one.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
The iOS store enforces that every binary needs a new number.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Those are used for the rating / visibility when editing dives.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This seems more intuitive. For editable combo boxes you need to tap on
the indicator, but for non-editable (readonly) ones, you can tap
anywhere and the dropdown is shown.
The code feels a bit clumsy, but seems to work in all cases.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
They always have a 10% darker background, and show a border if the combo
box has focus. This seems to look reasonably well in all situation we
use them.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
It seems that now all elements are correctly re-colored if the user changes
theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
With this we should finally get the correct button colors even when
switching color theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This one was missed in commit
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Getting the visual right is really hard. The anchors seem to mostly work,
but it still doesn't look exactly right, IMHO.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Incorrect reference to the Kirigami Units.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
I was convinced that I had fixed this while working on this set of patches,
but apparently I didn't. This simply hardcodes good colors.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This got forgotten earlier.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
I am confused how this worked and then got broken, but this appears to
once again fix the colors.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
hidePassiveNotification() is no longer supported.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This never ever worked to trigger a profile update. The code is
nonsensical as we cannot access the QMLProfile in a model delegate this
way from outside the delegate.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
If a dive changes, we should simply redraw the profile. This could be
improved by checking for the fields that might impact the profile at
all, but this is definitely a step in the right direction.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
The weird 'Component.onCompleted' always felt like the wrong way to do
this. Setting this directly from the model seems like the much cleaner
solution.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This actually created a recursive dependency - I didn't see any negative
visual effect, but lots of annoying warnings.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, not using our template combo box.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In reality I should make our TemplateComboBox capable of handling the
modifications needed here without yet another reimplementation. Maybe
I'll do that next. This at least makes things look right.
A couple of odd whitespace changes snuck in at the end.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, not using our text field / label (plus adding a subdued color for
the placeholder text).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was simply not using our labels / text fields, so it didn't pick up
our colors automatically.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Once again I couldn't fix this without making changes to Kirigami.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Once again I couldn't fix this without making changes to Kirigami.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Recently (674c20227b2), the call to ProfileWidget::clearHandlers()
was moved from PlannerWidgets::replanDive() to ProfileWidget2.
This cause a crash, because the code assumes that the number
of elements in the handles-vector the divepointplanner model
is the same.
Clearing the handles violates this assumption. It turns out
that the clearHandlers() function is broken anyway: it clear
the handles-vector, but not the gases-vector, which should
likewise have the same number of elements. It appears that
the clearHandlers() function is an artifact and it is
mysterious how this has worked so far. Remove.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
Again, the fact that you basically need to completely reimplement the
ComboBox in order to change some colors is frustrating.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is needed for the Export page.
And may I say for the record that it's rather surprising that in order
to change the color of one of those elements one ends up having to
completely re-implement them.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This now looks right for the dark theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This uses one of our fixes to Kirigami to allows us to set the correct
overlay color for our icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This uses one of our changes to Kirigami that allows us to set the
correct overlay color for our icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This seems like a reasonably serious bug in Kirigami.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
While the text name is 'light primary color' it really has to be a dark
blueish color to fit with the theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This requires more changes to Kirigami, but with this we get dark
drawers (the menus that slide in from the side) in the dark theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
We do theming very differently from what Kirigami intended. Mostly
that's because our code predates theirs. But also because Kirigami wants
and app to simply use an OS theme - whereas we want to be able to
provide different looks, independent from the OS theme.
Ideally we'd still use the existing methods to change the colors and
sizes of Kirigami UI elements, but for now this hack helps improve
readability of the title bar.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In the dive list the rendering of the line ended up being subject to
rounding errors. With this change we ensure that the thin line is always
shown.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was too big relative to the page layout.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This took up a lot of space and made the UI look stodgy.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
On some platforms the side buttons looked disjoint from the center
button. This fixes that problem.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is kind of a random choice - I don't see much value to build this
everywhere, but it's kinda neat to use this to test that the -all option works
correctly and does the right thing with WebKit now. And it will also ensure
that the downloader build isn't broken.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is kind of a silly optimization, but might make a huge difference in build
time on a Raspberry Pi.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was wrong when running -both in the past. We only want these
options for desktop builds.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is just adding the third option and then untangles some of the 'there are
only two options' based code.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
On clicking the DivePictureItem "trash" icon, the item would delete
the picture it represents in the currently displayed dive. This needed
an access to the global "displayed_dive" variable, which we want
to get rid of to make the profile more flexible. For example, we
want to render the profile for printing without messing with global
state.
One solution would be to save the dive with every DivePictureItem.
This commit follows a more Qt-ish strategy by handling this via
signals: The close button emits a signal that is recast by the
DivePictureItem and ultimately handled by the ProfileWidget2,
which knows which dive it represents.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
These were only calling the corresponding functions in the
base class. So just don't override them..?
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
The RemovePictures command filters the pictures provided by the
UI: only actually existing pictures are removed. The code was
buggy: the original list was copied and then the filtered list
was added. Thus, every picture was listed twice leading to
annoying warning messages. Remove the copy.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
To make the output more readable.
Moreover, fix a comment-typo.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
Berthold Stoeger
Dirk Hohndel