aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2015-09-10Uemis downloader: remove code not needed anymoreGravatar glerch
Cleaning up track_uemis_divespot because this function is not needed anymore. As I am loading the divespots now within do_uemis_import, I also adjusted the memory calculation - this is not completed yet. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: new logic for divespotsGravatar glerch
Changed the do_uemis_import to load divespots right after matching the dive details. Logic implemented to verify that we are not duplicating divespots by comparing the uuid from get_dive_site_by_uuid(dive->dive_site_uuid) with the one from get_dive_site_uuid_by_name Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: deleting code because of design changeGravatar glerch
Deleting unnecessary code to support future design change coming with the next patch Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: new routine to load divespotsGravatar glerch
Added load_uemis_divespot. This will be used later in do_uemis_import to improve the amount of divespots that must be loaded actually. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: new find divespot by diveidGravatar glerch
New routine to support finding a dive spot based on the dive id, this is needed due to the weird way Uemis is providing data. This function will be used in the uemis-downloader.c within do_uemis_import. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Uemis downloader: fix bug when creating dive siteGravatar glerch
Use dive->when when creating a dive site instead of time(NULL) as Dirk suggested Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Document simplified web access to cloud storage dataGravatar Dirk Hohndel
The backend now redirects you to the correct URL once you log in with your email address and password. So all the user needs to know is to go to https://cloud.subsurface-divelog.org Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Cloud storage: add another progress callbackGravatar Dirk Hohndel
This one sadly only appears to be called with 0% and 100% in my examples. Not sure what to do about that. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-10Save settings in closeEvent, not destructorGravatar Anton Lundin
This switches to use the closeEvent to save settings and cleanup instead of the destructor. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix another memory leak on uemis downloaderGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix memory leak on uemis downloaderGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Initialize variable before useGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix memory leaks in serial ftdiGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix memory leak on serial bluetoothGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Datatrak parsingGravatar Miika Turkia
I have some trouble understanding this code, but as there is a clear bug involved (null dereference), I ask others to verify if I am onto something. And if datatrak import still works with this patch. From af2935622b1f00f373ed38c8e3194e25504372b6 Mon Sep 17 00:00:00 2001 From: Miika Turkia <miika.turkia@gmail.com> Date: Wed, 9 Sep 2015 18:03:45 +0300 Subject: [PATCH] Fix null dereference and parsing logic Null dereference in the first change is obviously a bug. The parsing logic I only assume to be wrong and suggest that we discard dives that are deemed to be bogus. Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Whitespace cleanupGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09OSTCTools - remove useless pointer ldc_datGravatar Salvador Cuñat
This device_data_t pointer was a remnant from initial work. It is useless and can be safely removed. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09ReleaseNotes: update changes towards Beta 2Gravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Documentation: update french translation of user-manualGravatar Guillaume GARDET
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Exit with failure if the first dc_open method failsGravatar Claudiu Olteanu
If the dc_serial_*_open method fails then we should exit with an error and don't try to open the device using the native implementation. Signed-off-by: Claudiu Olteanu <olteanu.claudiu@ymail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Do not ignore the first tag on autocompletion.Gravatar Sander Kleijwegt
Signed-off-by: Sander Kleijwegt <sander@myowndomain.nl> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Replace the spinner with a progress dialog for cloud storage accessGravatar Dirk Hohndel
Since the spinner caused all kinds of problems inside VMs, wasn't shown at all for some people on Win10 and appeared to get stuck a lot and still left people with the perception that Subsurface was hung, this patch takes a more traditional approach and gives the user a progress dialog. An additional benefit of this is that the user now can cancel a hung transfer. The slightly weird passing in of the callback allows for the separation of UI and core logic code... Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09qthelper.cpp: don't hardcode the Dive m_duration as minutesGravatar Lubomir I. Ivanov
get_dive_duration_string() should be used in a similiar way to socialnetworks.cpp so that the Dive::put_duration() method sets the variable in the h:min format. Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09qthelper.cpp: use timeFormat and dateFormat for the Dive classGravatar Lubomir I. Ivanov
The Dive class has a method which sets the m_time and m_date members but it uses a custom format. By using the static dateFormat and timeFormat variables this helper class now uses the same date and time format as in the dive list. Fixes #920 Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Delay freeing of memory after useGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Fix a crash on divelogs.de exportGravatar Miika Turkia
Subsurface crashes when multiple dives are selected on divelogs.de export. The crash occurs on malloc that is called indirectly from xmlReadMemory(). Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Translation updatesGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-09Two small string changesGravatar Dirk Hohndel
Reported by Ettore Atalan on Trnasifex. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Only use DC_TRANSPORT_* with SSRF_CUSTOM_SERIALGravatar Anton Lundin
This if'defs DC_TRANSPORT_* use with SSRF_CUSTOM_SERIAL, because the enum doesn't exist when building against stock libdivecomputer. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Better import of libdivecomputer universal xmlGravatar Anton Lundin
This teaches subsurface how to understand more fields in the xml that libdivecomputers's universal tool generates. Signed-off-by: Anton Lundin <glance@acc.umu.se> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Update the script to build Mac BundleGravatar Dirk Hohndel
This is trying to clean things up quite a bit and make it less specific to my directory layout. It still calls the signing script that tries to sign things with my keys, so it won't work for others without tuning, but this should get you closer. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Disable Bluetooth option from GUI if SSRF_CUSTOM_SERIAL is undefinedGravatar Claudiu Olteanu
The Bluetooth implementation doesn't work if SSRF_CUSTOM_SERIAL is undefined. Therefore it is a good idea to remove it from the UI if the libdivecomputer version is wrong. Signed-off-by: Claudiu Olteanu <olteanu.claudiu@ymail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Uemis downloader: don't use unknown type u_int32_tGravatar Lubomir I. Ivanov
Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08User manual update: Location managementGravatar Willem Ferguson
1) Add text to cover location management 2) Delete duplicate text for entering dives manually and entering dives from a dive computer. The sections dealing with location, cylinders, weights, and other items on the Info tab were duplicated for these two types of data entry into Subsurface. This duplication is now removed. 3) Replace five screen shots Signed-off-by: Willem Ferguson <willemferguson@zoology.up.ac.za> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Documentation: update french translation of user-manualGravatar Guillaume GARDET
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-08Only store dive site uuid in dive if the dive site existsGravatar Dirk Hohndel
Don't store stale uuids. As a side effect this makes it easy to remove dive sites from the XML file (or the git repository) when duplicates have been added for some reason and the user wants to restart from scratch. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Uemis downloader: code cleanupGravatar glerch
Do some cleanup of the code, there might be more of that as I am still learning the Uemis code Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Uemis downloader: original dive number supportGravatar glerch
- enabled capturing of the original Uemis dive number - previousely the object_id was passed to dive as dive number - I am using a workaround (not nice but effective) by parsing the dive_no out of a copy of inbuf before the object_id is parsed. The reason why is that the dive_no comes before the object_id hence the normal parsing would miss it. Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Uemis downloader: multiple buddy supportGravatar glerch
- changed the uemis_add_string to support a delimiter in parameter 3 - passing each nickname to the parse_tag function appending dive->buddy with concatentated nicknames separaed by comma Signed-off-by: glerch <guido.lerch@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Planner notes: Show VPM-B conservatismGravatar Rick Walsh
Signed-off-by: Rick Walsh <rickmwalsh@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07CodingStype: add explanation how to install the QtCreator settingsGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Reset the index of the device if the Bth mode is disabledGravatar Claudiu Olteanu
If the Bluetooth download mode was disabled then remove the Bth address from the device or mount point section and reset the index. Signed-off-by: Claudiu Olteanu <olteanu.claudiu@ymail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Save Bluetooth download mode settingsGravatar Claudiu Olteanu
Save the dive computer download mode flag. In this way, if the user used Bluetooth mode to download its dives on his last session he doesn't need to open the Bth selection dialog if he wants to use the same device. Signed-off-by: Claudiu Olteanu <olteanu.claudiu@ymail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Updates to user manual: dive log printing and APD CCR importGravatar Willem Ferguson
Updates to the APD import interface that Miika has recently completed. Updates to reflect the new print interface. Added some images and modified existing text. Swapped APPENDIX E and APPENDIX F so that FAQs are at end of document. Updated appendix [F] dealing with customising print templates. Signed-off-by: Willem Ferguson <willemferguson@zoology.up.ac.za> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07Include dive site on divelogs exportGravatar Miika Turkia
Due to the new dive site management, we need to include this information before transforming the XML to divelogs.de format. Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07New location management for divelogs.de exportGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07CSV import: validate column countGravatar Miika Turkia
We need at least 23 columns when reading in Subsurface CSV. Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-07UDDF export: adapt to new dive site managementGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-06Build script: make sure we find the cmake files for our librariesGravatar Dirk Hohndel
This way cmake should pick the right libraries that we built earlier in the process. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2015-09-06Cmake: make Grantlee5 requiredGravatar Dirk Hohndel
Otherwise printing doesn't work. And we get weird build errors. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>