aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2021-01-01mobile/UI: consolidate to a single check boxGravatar Dirk Hohndel
It was very odd that we had two slightly different styled check boxes. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: fix the logic to keep input visibleGravatar Dirk Hohndel
Using the y coordinate of the component directly doesn't work if we use the component inside other components. Instead we need to grab the position relative to the flickable. The comment about needing the function for this to work seemed dubious. So for now I've removed that function and am setting the position directly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: trigger position check on focusGravatar Dirk Hohndel
Doing this check every time we get a 'pressed' signal for the input field seems excessive. We really only need to check when the input field gets focus - that's when the OS virtual keyboard might open and hide the field the user wants to edit. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: don't show warning if text field is not in flickableGravatar Dirk Hohndel
It's entirely reasonable to use the component in a context where we don't have a flickable. Simply don't try to reposition things in that case. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: ensure active input field stays visibleGravatar Dirk Hohndel
This reuses the logic we implemented in the SsrfTextField. Eventually we will need to clean up the inconsistent names for these elements. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: avoid pointless warningsGravatar Dirk Hohndel
These can create quite a bit of noise in the log. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: ensure that edited text is currentGravatar Dirk Hohndel
By removing focus from all input fields we can ensure that we have the correct data reflected when saving an edited dive. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile UI: avoid circular dependencyGravatar Dirk Hohndel
The relevant text field names are different depending on whether our combo box is editable or not. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: use our small label templateGravatar Dirk Hohndel
This saves 66 lines of code. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: provide more structured debug output for dive editGravatar Dirk Hohndel
Instead of always showing info about the location, allow all data to be captured in a more structured format - but only when the app is in verbose mode. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: don't try to set the combobox indexGravatar Dirk Hohndel
There's no point in doing that - we set the correct text and leave that in the editText and displayText for the combo box. If the user uses the drop down they can replace that. This works correctly for single people, and for multiple people the drop down doesn't work at all, anyway. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: don't show virtual keyboard when starting dive editGravatar Dirk Hohndel
When we start editing a dive the OS will open the virtual keyboard if any of the input fields have focus (which they might get when we set their content). The explicit closing of the keyboard might be overkill, but also doesn't appear to hurt. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01mobile/UI: add template for editable combo boxGravatar Dirk Hohndel
This makes the code easier to read and manage. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2021-01-01build-system: fix macOS QtCharts QML resourcesGravatar Dirk Hohndel
On macOS the cmake build system doesn't copy the QML resources into the app bundle and so we do that manually. I forgot to add that for QtCharts. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30build-system: fix Coverity scriptGravatar Dirk Hohndel
Trying to keep the different build environments consistent I messed up and dropped wget and curl from the Coverity build. Moving them to the beginning of the list so they stand out more. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30cleanup: fix typoGravatar Dirk Hohndel
Sorry about that. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30Cleanup: add another incorrect author name to the listGravatar Dirk Hohndel
This way the summaries are "more correct". Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30build-system: update OBS spec fileGravatar Dirk Hohndel
Contrary to the Launchpad builds, OBS isn't actually using the spec file that is included in the Subsurface source but instead maintains its own. So this is just updating to the version that has been tracked over there, mostly for reference. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30build-system: fix Launchpad packagingGravatar Dirk Hohndel
There are just so many places where I need to remember to update the package lists. Turns out I had forgotten to add libmtp to the Linux builds when we add the Garmin Descent mk2 support... Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30cleanup: remove obsolete macOS packaging filesGravatar Dirk Hohndel
Several of these stem back from when Subsurface was a Gtk2 app. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30cleanup: remove obsolete iOS packaging filesGravatar Dirk Hohndel
These have all been replaced with the current build process. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-30cleanup: remove obsolete Android scriptsGravatar Dirk Hohndel
These have all been replaced with the current qmake based build process. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29GitHub Actions: clearly disable the docker build tasksGravatar Dirk Hohndel
These haven't been used for a while and still create strange errors. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29update Windows READMEGravatar Dirk Hohndel
Pointing at the current build container. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29update INSTALL documentationGravatar Dirk Hohndel
Catching up with all of the changes to Qt installation and our build processes. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build script: move related code closer togetherGravatar Dirk Hohndel
This just makes it more obvious what we are doing. This appears only necessary on macOS. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build script: remove the long outdated Qt detectionGravatar Dirk Hohndel
We now require qmake to be found much earlier in the script so we can simply use that to get the right prefix path. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build script: fix typos and inconsistenciesGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: update Coverity build for QtChartsGravatar Dirk Hohndel
This was missing in the earlier GitHub Action updates. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system/trusty: use new Qt installerGravatar Subsurface CI
Update to Qt 5.12.10, latest OpenSSL, add QtChart, add other missing packages. Also switch to gcc-7 as our statistics code requires better C++17 support than what gcc-6 can offer. This then creates trusty-qt512:1.1 Signed-off-by: Subsurface CI <dirk@hohndel.org>
2020-12-29build-system: add QQuickWidgets to mobile buildGravatar Dirk Hohndel
Even though the mobile build doesn't have a UI for the statistics, yet, it already builds the base files. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: add QtCharts for CodeQL buildGravatar Dirk Hohndel
This fixes another GitHub Action failure. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: build Windows binaries with gcc 10.2Gravatar Dirk Hohndel
This simply uses a newer version of our build container which includes newer tools. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: add missing components for GitHub ActionsGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: compile with QtCharts moduleGravatar Berthold Stoeger
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29GitHub Actions: turn off building docker imagesGravatar Subsurface CI
This hasn't worked in quite a while. It was a good thought, but, yeah, no. Signed-off-by: Subsurface CI <dirk@hohndel.org>
2020-12-29cleanup: const-ify utc_mktime()Gravatar Berthold Stoeger
To make it clear that the struct tm is only used as an input parameter. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29cleanup: move monthname to time.cGravatar Berthold Stoeger
Weirdly, this function was declared in dive.h and defined in subsurface-startup.c. Let's move declaration and definition to more appropriate places, viz. subsurface-time.h and time.c. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29cleanup: remove getDivesInTrip() in qthelper.cppGravatar Berthold Stoeger
This function was not used anywhere. Moreover, remove a few unused includes from qthelper.h. Surprisingly, a number of users of qthelper.h depend on these, so readd them at the appropriate places. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: provide function that returns all shown divesGravatar Berthold Stoeger
This will be used by the statistics widget. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: internalize shown_dives in DiveFilter classGravatar Berthold Stoeger
one piece of global state removed! Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: move shown_dive from divelist.c to divefilter.cppGravatar Berthold Stoeger
Arguably, the number of filtered dives is a matter of the divefilter. Let's move it there. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: keep track on shown_dive on dive removal in DiveFilterGravatar Berthold Stoeger
When removing dives, the UndoCommands would keep track of the shown dives. When adding, they were calling into the filter instead. Let's remove this asymmetry. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: reset shown_dives in filterGravatar Berthold Stoeger
The shown_dives variable was reset by the dive_list code. Arguably, the filter should keep track of the number of shown dives, so move the resetting there. This means adding a new "reset()" member function to the filter and call that instead of "updateAll()" when the core data is reset. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-23build-system/Android: adapt the Google maps plugin nameGravatar Dirk Hohndel
This appears to be needed only for Android with Qt 5.15. Which means that this commit creates odd breakage in case someone were to try to build for Android with an older Qt version - but given that the current build process only works with Qt 5.14 or 5.15, I think this is an acceptable flaw. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: fix theming of About pageGravatar Dirk Hohndel
Can't believe I missed that one. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile: update version to 3.1.2Gravatar Dirk Hohndel
The iOS store enforces that every binary needs a new number. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: improve theming of spin boxGravatar Dirk Hohndel
Those are used for the rating / visibility when editing dives. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: open dropdown on any tap for readonly combo boxGravatar Dirk Hohndel
This seems more intuitive. For editable combo boxes you need to tap on the indicator, but for non-editable (readonly) ones, you can tap anywhere and the dropdown is shown. The code feels a bit clumsy, but seems to work in all cases. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: slight visual change to combo boxesGravatar Dirk Hohndel
They always have a 10% darker background, and show a border if the combo box has focus. This seems to look reasonably well in all situation we use them. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2025-01-13 06:46:09 +0000