aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2020-12-29build script: move related code closer togetherGravatar Dirk Hohndel
This just makes it more obvious what we are doing. This appears only necessary on macOS. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build script: remove the long outdated Qt detectionGravatar Dirk Hohndel
We now require qmake to be found much earlier in the script so we can simply use that to get the right prefix path. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build script: fix typos and inconsistenciesGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: update Coverity build for QtChartsGravatar Dirk Hohndel
This was missing in the earlier GitHub Action updates. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system/trusty: use new Qt installerGravatar Subsurface CI
Update to Qt 5.12.10, latest OpenSSL, add QtChart, add other missing packages. Also switch to gcc-7 as our statistics code requires better C++17 support than what gcc-6 can offer. This then creates trusty-qt512:1.1 Signed-off-by: Subsurface CI <dirk@hohndel.org>
2020-12-29build-system: add QQuickWidgets to mobile buildGravatar Dirk Hohndel
Even though the mobile build doesn't have a UI for the statistics, yet, it already builds the base files. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: add QtCharts for CodeQL buildGravatar Dirk Hohndel
This fixes another GitHub Action failure. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: build Windows binaries with gcc 10.2Gravatar Dirk Hohndel
This simply uses a newer version of our build container which includes newer tools. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: add missing components for GitHub ActionsGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-29build-system: compile with QtCharts moduleGravatar Berthold Stoeger
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29GitHub Actions: turn off building docker imagesGravatar Subsurface CI
This hasn't worked in quite a while. It was a good thought, but, yeah, no. Signed-off-by: Subsurface CI <dirk@hohndel.org>
2020-12-29cleanup: const-ify utc_mktime()Gravatar Berthold Stoeger
To make it clear that the struct tm is only used as an input parameter. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29cleanup: move monthname to time.cGravatar Berthold Stoeger
Weirdly, this function was declared in dive.h and defined in subsurface-startup.c. Let's move declaration and definition to more appropriate places, viz. subsurface-time.h and time.c. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29cleanup: remove getDivesInTrip() in qthelper.cppGravatar Berthold Stoeger
This function was not used anywhere. Moreover, remove a few unused includes from qthelper.h. Surprisingly, a number of users of qthelper.h depend on these, so readd them at the appropriate places. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: provide function that returns all shown divesGravatar Berthold Stoeger
This will be used by the statistics widget. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: internalize shown_dives in DiveFilter classGravatar Berthold Stoeger
one piece of global state removed! Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: move shown_dive from divelist.c to divefilter.cppGravatar Berthold Stoeger
Arguably, the number of filtered dives is a matter of the divefilter. Let's move it there. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: keep track on shown_dive on dive removal in DiveFilterGravatar Berthold Stoeger
When removing dives, the UndoCommands would keep track of the shown dives. When adding, they were calling into the filter instead. Let's remove this asymmetry. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-29filter: reset shown_dives in filterGravatar Berthold Stoeger
The shown_dives variable was reset by the dive_list code. Arguably, the filter should keep track of the number of shown dives, so move the resetting there. This means adding a new "reset()" member function to the filter and call that instead of "updateAll()" when the core data is reset. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-23build-system/Android: adapt the Google maps plugin nameGravatar Dirk Hohndel
This appears to be needed only for Android with Qt 5.15. Which means that this commit creates odd breakage in case someone were to try to build for Android with an older Qt version - but given that the current build process only works with Qt 5.14 or 5.15, I think this is an acceptable flaw. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: fix theming of About pageGravatar Dirk Hohndel
Can't believe I missed that one. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile: update version to 3.1.2Gravatar Dirk Hohndel
The iOS store enforces that every binary needs a new number. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: improve theming of spin boxGravatar Dirk Hohndel
Those are used for the rating / visibility when editing dives. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: open dropdown on any tap for readonly combo boxGravatar Dirk Hohndel
This seems more intuitive. For editable combo boxes you need to tap on the indicator, but for non-editable (readonly) ones, you can tap anywhere and the dropdown is shown. The code feels a bit clumsy, but seems to work in all cases. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: slight visual change to combo boxesGravatar Dirk Hohndel
They always have a 10% darker background, and show a border if the combo box has focus. This seems to look reasonably well in all situation we use them. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: repaint the combobox indicator on color changeGravatar Dirk Hohndel
It seems that now all elements are correctly re-colored if the user changes theme. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: initialize Kirigami theme to use our colorsGravatar Dirk Hohndel
With this we should finally get the correct button colors even when switching color theme. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: update location combobox for dive editGravatar Dirk Hohndel
This one was missed in commit Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile UI: make TemplateComboBox selectively editableGravatar Dirk Hohndel
Getting the visual right is really hard. The anchors seem to mostly work, but it still doesn't look exactly right, IMHO. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-23mobile/UI: fix trip details paddingGravatar Dirk Hohndel
Incorrect reference to the Kirigami Units. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile/UI: hardcore passiveNotification colorsGravatar Dirk Hohndel
I was convinced that I had fixed this while working on this set of patches, but apparently I didn't. This simply hardcodes good colors. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile/UI: make trip details edit theme awareGravatar Dirk Hohndel
This got forgotten earlier. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile/UI: again, correct side button colorsGravatar Dirk Hohndel
I am confused how this worked and then got broken, but this appears to once again fix the colors. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile/UI: stop using removed Kirigami interfaceGravatar Dirk Hohndel
hidePassiveNotification() is no longer supported. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile: remove non-functional codeGravatar Dirk Hohndel
This never ever worked to trigger a profile update. The code is nonsensical as we cannot access the QMLProfile in a model delegate this way from outside the delegate. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile/profile: listen to dive changes and redraw profileGravatar Dirk Hohndel
If a dive changes, we should simply redraw the profile. This could be improved by checking for the fields that might impact the profile at all, but this is definitely a step in the right direction. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-21mobile/profile: directly set up the diveIdGravatar Dirk Hohndel
The weird 'Component.onCompleted' always felt like the wrong way to do this. Setting this directly from the model seems like the much cleaner solution. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: remove incorrect code in ComboBoxGravatar Dirk Hohndel
This actually created a recursive dependency - I didn't see any negative visual effect, but lots of annoying warnings. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: fix theming of combo boxes in dive editGravatar Dirk Hohndel
Again, not using our template combo box. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: make dive download combo boxes theme awareGravatar Dirk Hohndel
In reality I should make our TemplateComboBox capable of handling the modifications needed here without yet another reimplementation. Maybe I'll do that next. This at least makes things look right. A couple of odd whitespace changes snuck in at the end. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: make filter entry / dives shown theme awareGravatar Dirk Hohndel
Again, not using our text field / label (plus adding a subdued color for the placeholder text). Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: cloud credentials follow our themingGravatar Dirk Hohndel
This was simply not using our labels / text fields, so it didn't pick up our colors automatically. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: make passive notification easier to readGravatar Dirk Hohndel
Once again I couldn't fix this without making changes to Kirigami. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: fix context drawer headerGravatar Dirk Hohndel
Once again I couldn't fix this without making changes to Kirigami. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20profile: remove clearHandlers function (fixes crash)Gravatar Berthold Stoeger
Recently (674c20227b2), the call to ProfileWidget::clearHandlers() was moved from PlannerWidgets::replanDive() to ProfileWidget2. This cause a crash, because the code assumes that the number of elements in the handles-vector the divepointplanner model is the same. Clearing the handles violates this assumption. It turns out that the clearHandlers() function is broken anyway: it clear the handles-vector, but not the gases-vector, which should likewise have the same number of elements. It appears that the clearHandlers() function is an artifact and it is mysterious how this has worked so far. Remove. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-12-20mobile/UI: correctly theme combo boxesGravatar Dirk Hohndel
Again, the fact that you basically need to completely reimplement the ComboBox in order to change some colors is frustrating. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile UI: style check boxes and radio boxesGravatar Dirk Hohndel
This is needed for the Export page. And may I say for the record that it's rather surprising that in order to change the color of one of those elements one ends up having to completely re-implement them. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: fix dive summary for dark themeGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: use theme colors for startup text and location warningGravatar Dirk Hohndel
This now looks right for the dark theme. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2020-12-20mobile/UI: correctly color the action button icons for dive listGravatar Dirk Hohndel
This uses one of our fixes to Kirigami to allows us to set the correct overlay color for our icons. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
generated by cgit v1.2.3-70-g09d2 (git 2.47.0) at 2025-01-12 05:37:03 +0000