aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2018-02-25Correctly suppress display of ICD table if prefs.show_icd is falseGravatar Stefan Fuchs
Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-25For prefs option show_icd add missing call for loadingGravatar Stefan Fuchs
Add the missing call to load the prefs option show_icd in function SettingsObjectWrapper::load() Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-24smtk-import: Add smtk2ssrf.desktop to sourcesGravatar Salvador Cuñat
Without this file AppImage won't build and travisbuild.sh will fail miserably. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com>
2018-02-24smtk-import: Upload .AppImage and .exe filesGravatar Salvador Cuñat
Upload windows installer and AppImage to Subsurface's repo Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com>
2018-02-24smtk-import: Add an AppImage for smtk2ssrfGravatar Salvador Cuñat
Build an AppImage for smtk2ssrf using previously build binaries. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com>
2018-02-24smtk-import: add windows building to travis-ciGravatar Salvador Cuñat
Prepare the building script to suport travis or set other automated builds, while keeping other options to manual builds. In before_install script, create needed directories, and dowload mdbtools sources. Add smtk2ssrf build script to travisbuild.sh Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com>
2018-02-24smtk-import: fit build script to run in travis buildsGravatar Salvador Cuñat
Set an "automatic" mode via parameter (or auto detected if running in travis environment) to skip the user prompt. Install the built binary, in automated builds, under the usual INSTALL_ROOT folder. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com>
2018-02-24smtk-import: Support SmartTrak import in travis buildsGravatar Salvador Cuñat
1.- Include needed dependencies (glib-2.0 and mdbtools) in .travis.yml 2.- Call smtk2ssrf-build.sh script *after* subsurface is done and AppImage is built, as the script will override subsurface's binary. Signed-off-by: Salvador Cuñat <salvador.cunat@gmail.com>
2018-02-24Add Derek control fileGravatar Dirk Hohndel
I want to start using Derek to check for Signed-off-by (or, more explicitly, the DCO) in pull requests. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2018-02-24Whitespace cleanup in core/divelogexportlogic.cppGravatar Stefan Fuchs
Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-24Correct comments for struct temperature_t value rangeGravatar Stefan Fuchs
Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-24Use duration_t for total_sac_time in struct stats_tGravatar Stefan Fuchs
Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-24Use temperature_t for temperatures in struct stats_tGravatar Stefan Fuchs
Use struct temperature_t for temperatures in struct stats_t and use get_temperature_string() when printing these temperatures for statistics and HTML export. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-24QML UI Mobile: correct margins on log pageGravatar Jan Mulder
Also a developer likes to see a nicely formatted page, so correct some bugs in margin handling on the log page. There was a strange multi-line whitespace on the top of the list, and the total width of the page was (initially) a little smaller than full page, so showing a small strip of the page left on the pageStack. This just looks weird. So again, cosmetics only. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-24Mobile QML UI: wideScreen property changeGravatar Jan Mulder
See also 15cdcdbc6. There, we introduced the wideScreen (set to true) to evade a (cosmetic) bug in (most likely) Kirigami. The top dive was partially obscured on the start of the app. And by setting the wideScreen to true, the application header became of a fixed height. Numerous changes further in Kirigami, we can now set this property to false. This results in a correctly displayed divelist at the start of the app, and *also* an application header that correcly hides itself when scrolling up, and displays itself again when scrolling down. So, a behavior that is common to, for example, mobile brouwsers. This all said. I still believe this is a workround for strange behavior. In fact, we should not need to set this wideScreen property at all, and Kirigami should behave correct in all cases (true, false, unset at our end). It behaves correctly when set to true or false, but still displays a partially hidden top item in the dive list when unset. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-24Mobile: new Kirigami SHAGravatar Jan Mulder
And sync again with Kirigami master. All safe QML improvements. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-24Revert "Mobile QML UI: fix more background colors (gpslist)"Gravatar Jan Mulder
This worked correctly while compiled against Qt 5.10.0, but after installing Qt 5.10.1 the behavior was just wrong. And as there seems no way to color the background of a Kirigami SwipeListItem, just revert this, and accept the (slightly) inconsistent coloring of the page (for now). This reverts commit 6700715b5dc1d314bc73800d8f8ec387d4d20d16. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-24Android build: use Qt 5.9.3Gravatar Jan Mulder
At least, now the Travis builds use the same Qt version as the production builds from Dirk that go to the AppStores. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-22Exit add_plan_to_notes() in plannernotes.c always via label finishedGravatar Stefan Fuchs
Replace an early "return" in add_plan_to_notes() with a "goto finished;" This was the initial idea of doing it plus it fixes a potential memory leak (missing free for icdbuffer). Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-22In configure DC dialogs don't use a space between values and unitsGravatar Stefan Fuchs
In the configure dive computer dialogs remove all the spaces between values and units. This makes it consistent with the standard used all over the Subsurface UI. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-22Remove space between pressure value and pressure unit in profileGravatar Stefan Fuchs
Bring one more value plus unit pair which is the pressure value printed in the profile in accordance with the coding style/UI style rule of not having a space between value and unit. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-20Build system: correctly find libdivecomputer includesGravatar Jan Mulder
Fully unsure when this got broken, but we tried to find the libdivecomputer includes based on the include file "hw.h". Interestingly, that file does not exisist (any more?) in libdivecomputer, so the search for the include fails. This is annoying, as the initial cmake fails on this in case of developer builds from QtCreator (which do not compile all dependencies like our home grown build scripts). The solution is simple: just find the includes for libdivecomputer based on exiting files in this lib. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-20Indicate direction of transition in verbatim planGravatar Robert C. Helling
Replace "Transition to" by "Ascent to" or "Descend to" Signed-off-by: Robert C. Helling <helling@atdotde.de>
2018-02-19QML UI: do not overflow right margin on BT textGravatar Jan Mulder
Trivial and cosmetics only fix. The width of the rescan button was forgotten, and this pushed the right margin to the right, causing the combo menus to overflow the right margin. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Consistently use the famous l for liters in info tabGravatar Stefan Fuchs
For salinity in info tab change the l character to the famous Subsurface "ℓ". Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
2018-02-17Coding-style: remove superfluous parenthesesGravatar Berthold Stoeger
Mostly replace "return (expression);" by "return expression;" and one case of "function((parameter))" by "function(parameter)". Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-02-17Mobile: again new Kirigami SHAGravatar Jan Mulder
While we are at this, just go to current master. Only QML improvements, and safe to upgrade. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Mobile QML UI: fix more background colors (gpslist)Gravatar Jan Mulder
And another one. The SwipeListItem also needs to have a set background color. Unfortunately, the lines between the individual SwipeListItem disappeared, so, set the smallest possible border on these items. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Mobile QML UI: color the application header correctlyGravatar Jan Mulder
Also, this got broken after the Kirigami to verion 2.2 in main.qml. So, set the header background color according to our theme setting. Notice, that there is a remaining issue here. We could color the text color in the header, but now, this seems impossible (or I do not understand how and where to set this). Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Mobile QML UI: fix background colorsGravatar Jan Mulder
For some reason, after the update of the main.qml to version 2.2, all Kirigami Pages and scrollablePages show up plain white. So now, set a proper background for these pages. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Mobile QML UI: Divelist hover/selected colorsGravatar Jan Mulder
This is subtle one. With the changing of the theme color, it appeared that the hover and selected colors in the divelist where wrong (as in, always blue-ish). This is easily solved by setting the activeBackgroundColor to our theme color, and Kirigami does the rest (tint and opaque settings for the different states a selected dive can be in). Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Mobile QML: main.qml to Kirigmi 2.2Gravatar Jan Mulder
This is a long standing issue. I wish to keep up with Kirigami developments including new versions of their controls, but this is not always easy. While we upgraded to Kirigmi 2.2 for most of our QML earlier, using this new version of main.qml breaks numerous stuff. In fact, so much that we just needed to wait. With the progress in Kirigmi, it is now possible to upgrade, with still some issues on our side to be fixed, but this is manageble now. The main show-stopper was a construct to set our theme colors, for example: Kirigami.Theme.highlightColor = Qt.binding(...) This is not posssible any more, as the Kirigami.Theme has made these readonly on their end. This commit just removes the assignments to the now readonly theme items. And the setting of a correct theme color for the action button. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-17Cleanup: Save hash from filename-to-hash map to git repositoryGravatar Berthold Stoeger
This unifies behavior of XML & git saving. Now, in both cases, the picture hash is extracted from the filename-to-hash map instead of using the picture structure. This seems more robust, because the picture structure is not necessarily updated by learnHash(). The latter may operate on a copy of the picture structure. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-02-17Cleanup: return copied string from hashstring()Gravatar Berthold Stoeger
The following statement in the hashstring() function: return hashOf[QString(filename)].toHex().data(); returns data of the temporary QByteArray generated by toHex(). Thus, the caller will access released memory, which could lead to data corruption. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-02-15Build: do include modules instead of filesGravatar Jan Mulder
Cleanup only. It seems a little weird to first define a CMAKE_MODULE_PATH search path and then explicitly include files including a hard coded path instead of letting the include command search for the modules we like to include. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-15Mobile: fix build after new Kirigami shaGravatar Jan Mulder
This is definitely a hack. Do not include the Kirigami resources (on static build). It causes double defined symbols in our setting. I would like a nicer fix for this issue, but failed to find one. For example, not adding the resource in our build causes the qrc file not to be generated. Manual generation of the resource file (using rcc) introduces the double symbols again. so it seems some Kirigami weirdness (but their staticcmake example compiles correctly). Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-15Mobile build: new Kirigami SHAGravatar Jan Mulder
While most new commits are QML improvements, there is a change in the Kirigami build related to static building (like we do), and Cmake restyles to make things more Qt compliant. As now the (generated) qrc_kirigami.cpp is included from kirigamiplugin.cpp, for static builds, our build failes on double defined symbols. Following commit deals with this fail. Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
2018-02-15UDCF import comment to changelogGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15Convert cylinder volume to metricGravatar Miika Turkia
This is a rough conversion from cuft to liters. Should be close enough when we don't have working pressure to do the real calculation. (As far as I know, this is the case with UDCF.) Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15Case insensitive string comparison for unitsGravatar Miika Turkia
Not really surprising, but a sample log that I received used different case for unit than I had expected. Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15Convert imperial pressures to metricGravatar Miika Turkia
This will convert cylinder start and end pressures from imperial to metric, when necessary. Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15Add imperial unit support for temperatureGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15UDCF import: use unit variableGravatar Miika Turkia
Simplify depth conversion from by using the unit variable and allowing dephtConvert template to do the work. Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15UDCF import: store units in a variableGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15Import: move some "functions" to commonTemplatesGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15UDCF import: support for imperial depthsGravatar Miika Turkia
Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-15Move XSLT depth conversion to commonTemplatesGravatar Miika Turkia
Moving depth conversion template from MacDive specific XSLT to commonTemplates. Signed-off-by: Miika Turkia <miika.turkia@gmail.com>
2018-02-12Switch to libdc version that compiles on iOSGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2018-02-12iOS build: add new file to qmake buildGravatar Dirk Hohndel
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2018-02-12iOS build: install sqlite3.pcGravatar Dirk Hohndel
Otherwise this gets rebuilt every time. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>