| Age | Commit message (Collapse) | Author |
|---|
|
I consider it more natural for example for the GPS menu
to stay open when an action is clicked. So this turns off
the general close but has to trigger it on individual items.
Signed-off-by: Robert C. Helling <helling@atdotde.de>
|
|
Sorry, this introduces a new string...
Signed-off-by: Robert C. Helling <helling@atdotde.de>
|
|
Signed-off-by: Murillo Bernardes <mfbernardes@gmail.com>
|
|
And again, no visual changes.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
Tested fine without visual changes.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
In commit bdf6dc78281bec2, we pulled in some changes from Kirigami.
I checked all the new commits and they seemed just fine, and a
test (on desktop) on both Qt 5.9.1. and 5.9.2 showed no obvious
problems.
However, some time later, working on something else, I compiled
from Android to test, and saw some strange behavior in the dive
list. The topmost dive is partially hidden behind the application
header on startup of the app, but can be pulled down. Not a big
deal, but is does not look right.
After tedious testing, bisecting, etc, I found commit
d0f3941a4d7f4d4c6 in Kirigami (obviosuly, it was not clear from
the start that it was in Kirigami, as I could well have been
some error in Subsurface, or even Qt). Mentioned commit is
trivial, and handles with the wideScreen property of the
application window. With wideScreen = false, the bug is
visible, when true the bug is gone.
This all said. Just set the wideScreen to true, which can
definitely be considered a workaround. I exspect that this
commit can be reverted later on when Kirigami is fixed.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
We need a white path drawn on the dark action button, but a black path
drawn for the main menu.
(looks like a white space change snuck in here)
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
It appears that the onCompleted of the StartPage item is triggered
before the onCompleted of the rootItem. This is logical as the
Startpage is a child of the rootItem. And, yes, this does matter.
As the divelist also contains the logic for initial cloud
registration (and is the default page shown in a state where
the cloud credentials are valid (CS_VERIFIED state)), we need to
know the correct credential state at start of the app.
The move of this one line of code makes sure of that, in addition
to setting the credential state from the preferences. Now, the
setupActions function can reference correct credential data.
This is further preparation for a better cloud creation
process from mobile.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
Having two different enums around with more or less the same
definition has lead to unclear code. After removing two not needed
states on the mobile end, the remaining step to one enum for the
credential state becomes almost is simple rename operation.
Unfortunately, I do not know a way to embed a plain C enum
from pref.h into the QMLManager object. So after this, there
are still 2 enums around, but now identical.
This commit is not changing any functionality.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
This is a no-brainer removal of the VALID_EMAIL state used in QMLManager.
All current usage of this state is "if state is VALID or VALID_EMAIL",
so there is no distinction between the two states.
It is even a little different. The comment suggests "when we can open
a local cloud storage, tied to a cloud account (so explicitly not
the no-cloud status), we have at least a valid email". While this
is formally true, this implies that there is also a cloud account
on the cloud server (ie. the cloud account is in a VERIFIED state).
In other words: currently, there can't exist a valid local storage
that is tied to a valid email adress, without valid cloud account
on the server.
Notice that this touches the discussion on GitHub for commit
e76f527fe530636 (pull request #520). Can we implement the creation
of a valid cloud account without data link to the cloud server?
Currently, we need the server to confirm the email address (for
example for uniqueness reasons on server side). Obviously, we could
hack our way out of this, but we have a perfect solution already
in place. Create a no-cloud account, and transfer that later to
a true and valid cloud account.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
This reverts commit d22f67925ef4893832c26deb44fef50589c6fff8.
|
|
Removed some unused alias defines.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
In commit e9503cfa3d1740 re-coloring of the status bar was
forgotten. Added here.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
In most places we wrongly used the darker primary color instead of the primary color.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Kirigami prevents us from altering the color of the gps icon in the action menu. So let's display an gps fix icon in the lower left corner of the drawer when the location services is running, colored to match the themes primary accent color.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Move the location services switch to the GPS menu, indicate both with icon and text if the service is active or not.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
The credential status has nothing to do with GPS functionality.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Simple typo on the overlay drawer.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Addresses: #492
Signed-off-by: Rick Walsh <rickmwalsh@gmail.com>
Had a bit of rebase issue with this one.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Move the locations service switch to the GPS section of the preferences page.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
As per title.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
The title says it all.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Add an icon to each item in the global drawer
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Add a checkbox to the preferences page to facilitate selective visibility of the developer menu. With the coresponding function in qmlmanager.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Change the order of the items in the global drawer and change the name of some of them.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Fixes: #490 items 1) and 2).
1) Reference to isBluetooth.leftPadding is removed as the isBooltooth
checkbox is gone.
2) Do not set background color of downloaded dives. The checkbox is used
to denote "selected or not".
In addition, incorrect references to subsurfaceTheme.PrimaryColor (which
does not exist) are replaced by the correct subsurfaceTheme.primaryColor.
Finally, an obvious copy/paste error width: childrenRect.height. that
is supposed to be width: childrenRect.width.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
This sets the color of the action side-buttons to the same color as the overlay drawer.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Also style all three drop downs the same (otherwise the left edge of the
text doesn't align).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In order for the theme styilng to work we need the materials definitions.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Simple typo.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
The built in theme in Kirigami has special variables for sertain objects, this sets the correct color for each object to match our themes.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
THe editable textboxes rely on the material theme to set the correct colors. This sets the appropriate colors for each theme.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
This adds separate colors for the overlay drawer background for light and dark themes.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
This adds style to the GPS services checkbox so that it matches the theme.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
This changes the pink primary color to match the tone of the blue primary color.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
This sets the background color to the recommended hue for dark themes.
Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
|
|
Latest Kirigami master allows us to turn off reachability mode. In
general this had been rather confusing to our users and it seems to
somewhat conflict with the pull down to refresh of the dive list.
Latest Kirigami also changes the behavior of refresh slightly, you now
need to pull "down" for at least 500ms before it triggers. So, with this
change and the latest Kirigami, hopefully the user experience for
refresh is good enough that we can consider keeping it enabled and use
it as an equivalent to manual sync (even in offline mode).
See #454
See #456
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Restyle construction of toast message and enable translation for it.
Further, removed newline characters as they break the lines at
non-logical positions.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Here I confused myself with "dark" theme and the "darkerPrimary"
colorls...
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This color is used for more than just the dive list.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
And reorganize settings and preferences a bit.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Let's have names for the colors in each theme and assign those
named values to the theme colors when switching themes. This
way other pages can access the colors that are not in the current
theme (for example for a theme switcher).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This requires Kirigami master past 2.2.0 (which explains commit 001ff1b9
"QML UI: switch to Kirigami master").
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This code is based on code from Marco Martin from the Kirigami Android
sample app. In order to simplify the QML code the QMLManager function is
there for all OSs, but it's a no-op on anything but Android.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This isn't great, yet, but a first step to show that this is possible
(and in doing so I found quite a few spots where the colors weren't
correctly propagating, yet).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
By making the assignments to the Kirigami Theme colors Qt bindings
things get correctly updated when switching.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
Robert C. Helling
Murillo Bernardes
Jan Mulder
Dirk Hohndel
Joakim Bygdell