| Age | Commit message (Collapse) | Author |
|---|
|
This gets us better log messages and better spacing - but it's far from
good and all of this should be squashed into one working version in the
end.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Copy paste of the other combo boxes.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
Use Q_PROPERTYs of the StatsManager to correctly set
the current index of comboboxes after a state changed.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
This doesn't look great, but it's already part of the breeze-icons,
so it's very easy to add - and it's better than no icon.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This has been a thorn in my side for a long time. The old code was
terrible and insanely fragile. The new code is really dumb and quite
fragile. So definitely an improvement?
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This adds a reasonably flexibile mobile page that tries to do the right
thing for both portrait and landscape mode. In order to get the most out
of a mobile screen, it's implemented in a way that always gives it the
full screen (it does so by emptying out the page stack and being the
only page shown - brutal, but effective).
This commit also contains a bunch of other random cleanups that didn't
really justify being in separate commits.
Parts of this was written by Berthold, hence the double SOB.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
|
|
It was very odd that we had two slightly different styled check boxes.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Using the y coordinate of the component directly doesn't work if we use
the component inside other components. Instead we need to grab the
position relative to the flickable.
The comment about needing the function for this to work seemed dubious.
So for now I've removed that function and am setting the position
directly.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Doing this check every time we get a 'pressed' signal for the input
field seems excessive. We really only need to check when the input field
gets focus - that's when the OS virtual keyboard might open and hide the
field the user wants to edit.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
It's entirely reasonable to use the component in a context where we
don't have a flickable. Simply don't try to reposition things in that
case.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This reuses the logic we implemented in the SsrfTextField.
Eventually we will need to clean up the inconsistent names for these
elements.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
These can create quite a bit of noise in the log.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
By removing focus from all input fields we can ensure that we have the
correct data reflected when saving an edited dive.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
The relevant text field names are different depending on whether our
combo box is editable or not.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This saves 66 lines of code.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
There's no point in doing that - we set the correct text and leave that
in the editText and displayText for the combo box. If the user uses the
drop down they can replace that. This works correctly for single people,
and for multiple people the drop down doesn't work at all, anyway.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
When we start editing a dive the OS will open the virtual keyboard if
any of the input fields have focus (which they might get when we set
their content).
The explicit closing of the keyboard might be overkill, but also doesn't
appear to hurt.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This makes the code easier to read and manage.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Can't believe I missed that one.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Those are used for the rating / visibility when editing dives.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This seems more intuitive. For editable combo boxes you need to tap on
the indicator, but for non-editable (readonly) ones, you can tap
anywhere and the dropdown is shown.
The code feels a bit clumsy, but seems to work in all cases.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
They always have a 10% darker background, and show a border if the combo
box has focus. This seems to look reasonably well in all situation we
use them.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
It seems that now all elements are correctly re-colored if the user changes
theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
With this we should finally get the correct button colors even when
switching color theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This one was missed in commit
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Getting the visual right is really hard. The anchors seem to mostly work,
but it still doesn't look exactly right, IMHO.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Incorrect reference to the Kirigami Units.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This got forgotten earlier.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
I am confused how this worked and then got broken, but this appears to
once again fix the colors.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
hidePassiveNotification() is no longer supported.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This never ever worked to trigger a profile update. The code is
nonsensical as we cannot access the QMLProfile in a model delegate this
way from outside the delegate.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
The weird 'Component.onCompleted' always felt like the wrong way to do
this. Setting this directly from the model seems like the much cleaner
solution.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This actually created a recursive dependency - I didn't see any negative
visual effect, but lots of annoying warnings.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, not using our template combo box.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In reality I should make our TemplateComboBox capable of handling the
modifications needed here without yet another reimplementation. Maybe
I'll do that next. This at least makes things look right.
A couple of odd whitespace changes snuck in at the end.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, not using our text field / label (plus adding a subdued color for
the placeholder text).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was simply not using our labels / text fields, so it didn't pick up
our colors automatically.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, the fact that you basically need to completely reimplement the
ComboBox in order to change some colors is frustrating.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is needed for the Export page.
And may I say for the record that it's rather surprising that in order
to change the color of one of those elements one ends up having to
completely re-implement them.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This now looks right for the dark theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This uses one of our fixes to Kirigami to allows us to set the correct
overlay color for our icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This uses one of our changes to Kirigami that allows us to set the
correct overlay color for our icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This requires more changes to Kirigami, but with this we get dark
drawers (the menus that slide in from the side) in the dark theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In the dive list the rendering of the line ended up being subject to
rounding errors. With this change we ensure that the thin line is always
shown.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was too big relative to the page layout.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This took up a lot of space and made the UI look stodgy.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
With the updates to Kirigami I slightly modified the hack that we use to
implement that, as a result we call pop() directly on the globalDrawer.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This used to work, but with current QML/Kirigami it throws an error.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
Dirk Hohndel
Berthold Stoeger