| Age | Commit message (Collapse) | Author |
|---|
|
Can't believe I missed that one.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Those are used for the rating / visibility when editing dives.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This seems more intuitive. For editable combo boxes you need to tap on
the indicator, but for non-editable (readonly) ones, you can tap
anywhere and the dropdown is shown.
The code feels a bit clumsy, but seems to work in all cases.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
They always have a 10% darker background, and show a border if the combo
box has focus. This seems to look reasonably well in all situation we
use them.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
It seems that now all elements are correctly re-colored if the user changes
theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
With this we should finally get the correct button colors even when
switching color theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This one was missed in commit
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Getting the visual right is really hard. The anchors seem to mostly work,
but it still doesn't look exactly right, IMHO.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Incorrect reference to the Kirigami Units.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This got forgotten earlier.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
I am confused how this worked and then got broken, but this appears to
once again fix the colors.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
hidePassiveNotification() is no longer supported.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This never ever worked to trigger a profile update. The code is
nonsensical as we cannot access the QMLProfile in a model delegate this
way from outside the delegate.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
The weird 'Component.onCompleted' always felt like the wrong way to do
this. Setting this directly from the model seems like the much cleaner
solution.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This actually created a recursive dependency - I didn't see any negative
visual effect, but lots of annoying warnings.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, not using our template combo box.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In reality I should make our TemplateComboBox capable of handling the
modifications needed here without yet another reimplementation. Maybe
I'll do that next. This at least makes things look right.
A couple of odd whitespace changes snuck in at the end.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, not using our text field / label (plus adding a subdued color for
the placeholder text).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was simply not using our labels / text fields, so it didn't pick up
our colors automatically.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Again, the fact that you basically need to completely reimplement the
ComboBox in order to change some colors is frustrating.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is needed for the Export page.
And may I say for the record that it's rather surprising that in order
to change the color of one of those elements one ends up having to
completely re-implement them.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This now looks right for the dark theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This uses one of our fixes to Kirigami to allows us to set the correct
overlay color for our icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This uses one of our changes to Kirigami that allows us to set the
correct overlay color for our icons.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This requires more changes to Kirigami, but with this we get dark
drawers (the menus that slide in from the side) in the dark theme.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
In the dive list the rendering of the line ended up being subject to
rounding errors. With this change we ensure that the thin line is always
shown.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was too big relative to the page layout.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This took up a lot of space and made the UI look stodgy.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
With the updates to Kirigami I slightly modified the hack that we use to
implement that, as a result we call pop() directly on the globalDrawer.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This used to work, but with current QML/Kirigami it throws an error.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Simply because it bugged me.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Our half-assed manual build of Kirigami was becoming completely unmaintainable.
So let's try to use the build method that the Kirigami team recommends. Which
unfortunately requires us to have access to the KDE extra cmake modules (ECM).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Thanks to Johan, one of our Swedish translators for noticing this
oversight.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Google play now requires that we show an explicit notification when turning
on background location. This is an attempt to fulfill that requirement - we
won't know if this is 'good enough' until we submit the app, though.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
I don't recall why we removed that text, but this makes it much clearer
that the service is active.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
A silly copy and paste error caused us to overwrite the gas mixes for
all the tanks with the gas mix in the first tank.
Fixes #2913
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
It appears that multi line attributes silently fail. Without this change, the Download
button is enabled if vendor and product are chosen, even if there isn't a connection
selected. With this change (having all three conditions on the same line) the code
works as expected.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This seems like the easiest way to show the state without disrupting the UI
elsewhere. Directly below the email address used for cloud storage.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Having a lot of tags (or more precisely, a tags string that is very long) could
cause the width of the dive details view to extend past the width of the the
page. The txtTags label was missing a maximum width, and to make the result
more useful, I also added correct wrapping and elide to the mix (stupidly, we
had the wrap and width for the fixed name of the field ('Tags'), but not for
the user determined content of that field).
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
The UI is ugly, and of course this is hidden in the developer options that have
to first be enabled in the advanced settings. As I mentioned in the previous
commit, I believe the actual risk that something gets damaged here is very low,
but still, explaining this so it makes sense to the casual user may be a bit...
difficult.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Every time I edit main.qml, QtCreator fixes this for me. And then I filter it
from the commit to not mix white space and actual changes. So let's just get
this fixed and move on.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This is a partial revert of commit 99438121c4 ("mobile/dive-edit: use template
components and theme colors")
Clearly the information given in the Qt documentation on how to theme ComboBox
is flat out broken. The trade-off between 'better dark theme' and 'broken user
experience' is fairly easy to make.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
Another small step to make the dark theme at least marginally useful.
We now use our template components and add the necessary elements to have
consistent text color.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This was all hard coded and wrong.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
I noticed that the download from dive computer page looked especially bad
in the dark theme (a user sent us some screenshots for a different reason)
and a quick look at the sources showed that we weren't using our template
label. Switching to that gives us the correct size by default so we can
drop all those explicit font size parameters. And we get the correct color
as used in the theme.
One random whitespace cleanup snuck into this commit. Oh well.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
So far the user can't edit them, but at least they are now shown as
part of the dive details. Usage of tags varries widely, I've seen
people who use a LOT of tags to classify their dives, so I'm giving
this a complete row by itself.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
|
This always seemed odd - the location looked like it sat 'low' on the
screen.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
|
Dirk Hohndel