From 01cd09c77a4be0ea7072e0cefac62f07c4a29c27 Mon Sep 17 00:00:00 2001
From: Tomaz Canabrava <tomaz.canabrava@intel.com>
Date: Thu, 13 Nov 2014 17:37:54 -0200
Subject: Fix use of QString

We should use references when we are not wanting to make a copy
of it.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
---
 qthelper.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/qthelper.cpp b/qthelper.cpp
index e165e85ad..0c1c68ab1 100644
--- a/qthelper.cpp
+++ b/qthelper.cpp
@@ -324,7 +324,6 @@ void selectedDivesGasUsed(QVector<QPair<QString, int> > &gasUsedOrdered)
 {
 	int i, j;
 	struct dive *d;
-	QString gas;
 	QMap<QString, int> gasUsed;
 	for_each_dive (i, d) {
 		if (!d->selected)
@@ -337,7 +336,7 @@ void selectedDivesGasUsed(QVector<QPair<QString, int> > &gasUsedOrdered)
 				gasUsed[gasName] += diveGases[j].mliter;
 			}
 	}
-	Q_FOREACH(gas, gasUsed.keys()) {
+	Q_FOREACH(const QString& gas, gasUsed.keys()) {
 		gasUsedOrdered.append(qMakePair(gas, gasUsed[gas]));
 	}
 	qSort(gasUsedOrdered.begin(), gasUsedOrdered.end(), lessThan);
-- 
cgit v1.2.3-70-g09d2