From 10e567515161f23510874236efd2f105c033ecec Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sat, 24 May 2014 13:55:18 -0700 Subject: Dive list: work around odd problem with selections According to the documentation clearSelection() should emit selectionChanged() - but I can verify in the debugger that sometimes this doesn't appear to happen - consequently our notion of what's selected gets confused. To work around this, after calling clearSelection() we simply manuall deselect all dives. Signed-off-by: Dirk Hohndel --- qt-ui/divelistview.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qt-ui/divelistview.cpp b/qt-ui/divelistview.cpp index 91b3dadf5..1f716ed57 100644 --- a/qt-ui/divelistview.cpp +++ b/qt-ui/divelistview.cpp @@ -190,8 +190,13 @@ void DiveListView::selectTrip(dive_trip_t *trip) void DiveListView::unselectDives() { selectionModel()->clearSelection(); - if (amount_selected != 0) - qDebug() << "selection information inconsistent"; + // clearSelection should emit selectionChanged() but sometimes that + // appears not to happen + int i; + struct dive *dive; + for_each_dive(i, dive) { + deselect_dive(i); + } } QList DiveListView::selectedTrips() -- cgit v1.2.3-70-g09d2