From 272f85bb244462acf09cb4235a9b176f68f75a5f Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Tue, 7 Oct 2014 20:43:45 -0400 Subject: Fix silly crash Who the heck uses strcpy? Signed-off-by: Dirk Hohndel --- dive.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dive.c b/dive.c index 1efdedef4..ea771f94e 100644 --- a/dive.c +++ b/dive.c @@ -2486,9 +2486,11 @@ void set_save_userid_local(short value) void set_userid(char *rUserId) { - prefs.userid = (char *) malloc(MAX_USERID_SIZE); - if (prefs.userid && rUserId) - strcpy(prefs.userid, rUserId); + prefs.userid = (char *) malloc(MAX_USERID_SIZE + 1); + if (prefs.userid && rUserId) { + strncpy(prefs.userid, rUserId, MAX_USERID_SIZE); + prefs.userid[MAX_USERID_SIZE] = 0; + } } #undef MAX_USERID_SIZE -- cgit v1.2.3-70-g09d2