From 2ad3696230e5bbd4f5a339121812d27e857c1789 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 26 Apr 2020 18:57:51 +0200 Subject: cleanup: make DiveListView slots private It makes reasoning about code so much easier when one knows that functions cannot be accessed from the outside. Therefore, make a number of DiveListView slots private. Moreover, unslotize functions that never were used in connect calls. Signed-off-by: Berthold Stoeger --- desktop-widgets/divelistview.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/desktop-widgets/divelistview.h b/desktop-widgets/divelistview.h index 9b5d2d7d8..502d0905e 100644 --- a/desktop-widgets/divelistview.h +++ b/desktop-widgets/divelistview.h @@ -28,19 +28,21 @@ public: QList selectedTrips(); static QString lastUsedImageDir(); static void updateLastUsedImageDir(const QString &s); + void loadImages(); + void loadWebImages(); signals: void divesSelected(); public slots: - void toggleColumnVisibilityByIndex(); void reloadHeaderActions(); +private +slots: + void toggleColumnVisibilityByIndex(); void sortIndicatorChanged(int index, Qt::SortOrder order); void removeFromTrip(); void deleteDive(); void markDiveInvalid(); void markDiveValid(); - void rowsInserted(const QModelIndex &parent, int start, int end) override; - void reset() override; void mergeTripAbove(); void mergeTripBelow(); void newTripAbove(); @@ -50,12 +52,12 @@ slots: void splitDives(); void renumberDives(); void shiftTimes(); - void loadImages(); - void loadWebImages(); void diveSelectionChanged(const QVector &indices); void currentDiveChanged(QModelIndex index); void tripChanged(dive_trip *trip, TripField); private: + void rowsInserted(const QModelIndex &parent, int start, int end) override; + void reset() override; void setSelection(const QRect &rect, QItemSelectionModel::SelectionFlags flags) override; void unselectDives(); void mouseReleaseEvent(QMouseEvent *event) override; -- cgit v1.2.3-70-g09d2