From 2c689964ab5578d7df1b77e4d19a8e02218163e4 Mon Sep 17 00:00:00 2001 From: Anton Lundin Date: Wed, 11 Dec 2013 21:21:49 +0100 Subject: Don't use old pointer after realloc If realloc moved the memory, we shouldn't try to access it. realloc copied that memory so access it via the new function instead. Signed-off-by: Anton Lundin Signed-off-by: Dirk Hohndel --- file.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/file.c b/file.c index 08c6a8309..9fd44d90f 100644 --- a/file.c +++ b/file.c @@ -117,12 +117,14 @@ static int try_to_xslt_open_csv(const char *filename, struct memblock *mem, char */ buf = realloc(mem->buffer, mem->size + strlen("")); if (buf != NULL) { - memmove(buf + 5, mem->buffer, mem->size); + memmove(buf + 5, buf, mem->size); memcpy(buf, "", 5); - memcpy(mem->buffer + mem->size + 5, "", 7); - mem->buffer = buf; + memcpy(buf + mem->size + 5, "", 7); mem->size += strlen(""); + mem->buffer = buf; } else { + /* we can atleast try to strdup a error... */ + *error = strdup("realloc failed in __func__\n"); free(mem->buffer); return 1; } -- cgit v1.2.3-70-g09d2