From 3b809f2cd45746bebdc844adec11d157ae4deea1 Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" Date: Wed, 7 Oct 2015 12:59:13 +0300 Subject: dive.h: don't declare force_fixup_dive() in the header The compiler complains that said static (not-inline) function in declared in the header but has no definition. The function is only used as a helper in dive.c so so this simply acts as a forward declaration and we can safely remove it from dive.h. The same forward declaration can be in dive.c. Since dive.h is include in *many* translation units, this causes a lot instances of the same warning to be show. If the function becomes part of the API, the static keyword needs to be removed and the declaration needs to be added in the header again. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel --- dive.h | 1 - 1 file changed, 1 deletion(-) diff --git a/dive.h b/dive.h index f0397544f..cef1106fd 100644 --- a/dive.h +++ b/dive.h @@ -721,7 +721,6 @@ extern void fixup_dc_duration(struct divecomputer *dc); extern int dive_getUniqID(struct dive *d); extern unsigned int dc_airtemp(struct divecomputer *dc); extern unsigned int dc_watertemp(struct divecomputer *dc); -static void force_fixup_dive(struct dive *d); extern int split_dive(struct dive *); extern struct dive *merge_dives(struct dive *a, struct dive *b, int offset, bool prefer_downloaded); extern struct dive *try_to_merge(struct dive *a, struct dive *b, bool prefer_downloaded); -- cgit v1.2.3-70-g09d2