From 4a1b9312f38222af6ef1f19b8551cfdeb47ad8df Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sat, 15 Mar 2014 13:46:35 -0700 Subject: Don't check for tank size information only on first tank commit d681bdcb6308 ("Only use default cylinder for first one") has a stupid bug in that it only calls get_tanksize for the first tank. That's of course completely bogus. Thanks to Linus for catching this. Reported-by: Linus Torvalds Signed-off-by: Dirk Hohndel --- libdivecomputer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdivecomputer.c b/libdivecomputer.c index c0c8e0bbb..d6f2d60b1 100644 --- a/libdivecomputer.c +++ b/libdivecomputer.c @@ -126,7 +126,7 @@ static int parse_gasmixes(device_data_t *devdata, struct dive *dive, dc_parser_t /* for the first tank, if there is no tanksize available from the * dive computer, fill in the default tank information (if set) */ - if (i == 0 && !get_tanksize(devdata, data, dive->cylinder, i)) + if (!get_tanksize(devdata, data, dive->cylinder, i) && i == 0) fill_default_cylinder(&dive->cylinder[i]); } return DC_STATUS_SUCCESS; -- cgit v1.2.3-70-g09d2