From 58d37e02001d7f54baf35b72dd1323b8886153d9 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Sat, 30 Nov 2013 09:18:01 -0800 Subject: Fix uninitialised variable read Found by Dr. Memory, run by Lubomir: Error #48: UNINITIALIZED READ: reading register al # 0 StarWidget::mouseReleaseEvent() [qt-ui/starwidget.cpp:29] Signed-off-by: Thiago Macieira Signed-off-by: Dirk Hohndel --- qt-ui/starwidget.cpp | 3 ++- qt-ui/starwidget.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/qt-ui/starwidget.cpp b/qt-ui/starwidget.cpp index 30c38808c..12b400124 100644 --- a/qt-ui/starwidget.cpp +++ b/qt-ui/starwidget.cpp @@ -63,7 +63,8 @@ void StarWidget::setCurrentStars(int value) StarWidget::StarWidget(QWidget* parent, Qt::WindowFlags f): QWidget(parent, f), - current(0) + current(0), + readOnly(false) { if (!activeStar) { activeStar = new QPixmap(); diff --git a/qt-ui/starwidget.h b/qt-ui/starwidget.h index 10a8a3073..9620bc62e 100644 --- a/qt-ui/starwidget.h +++ b/qt-ui/starwidget.h @@ -30,10 +30,11 @@ protected: private: int current; + bool readOnly; + static QPixmap* activeStar; static QPixmap* inactiveStar; QPixmap grayImage(QPixmap *coloredImg); - bool readOnly; }; #endif // STARWIDGET_H -- cgit v1.2.3-70-g09d2