From 621d00d8919d9ca07082fdf3dfb8118a1345b29d Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 22 Mar 2020 16:01:34 +0100 Subject: cleanup: don't call uiLanguage() in qPref::loadSync() uiLanguage() initializes the language fields from the preferences values. It is unclear why this function is called in qPref::loadSync() *before* the fields are loaded from disk. It can only initialize to the default values anyway. After qPref::loadSync() uiLanguage() is called again so that everything can be initialized with the correct perferences values. Remove the first call. If things break, let's fix them in a sensible way. Signed-off-by: Berthold Stoeger --- core/settings/qPref.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/settings/qPref.cpp b/core/settings/qPref.cpp index 522a74c6d..4254a2dac 100644 --- a/core/settings/qPref.cpp +++ b/core/settings/qPref.cpp @@ -23,9 +23,6 @@ void qPref::loadSync(bool doSync) { - if (!doSync) - uiLanguage(NULL); - // the following calls, ensures qPref* is instanciated, registred and // that properties are loaded qPrefCloudStorage::loadSync(doSync); -- cgit v1.2.3-70-g09d2