From 62e4c4069b517e97660452edd70f65d3cdb15e35 Mon Sep 17 00:00:00 2001 From: Venkatesh Shukla Date: Sat, 5 Apr 2014 21:29:34 +0530 Subject: Fix divelogs.de upload error The order of arguments to fread was incorrect. In case of arguments "streamsize, 1" the returning value is 1, and hence due to membuf[streamsize] = 0; line, membuf ends up being one character long. Fixed it by exchanging arguments to "1, streamsize". This way, streamsize has the correct value. Fixes #483 Signed-off-by: Venkatesh Shukla Acked-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel --- qt-ui/subsurfacewebservices.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp index 707746573..a8bce4a72 100644 --- a/qt-ui/subsurfacewebservices.cpp +++ b/qt-ui/subsurfacewebservices.cpp @@ -159,7 +159,7 @@ bool DivelogsDeWebServices::prepare_dives_for_divelogs(const QString &tempfile, rewind(f); membuf = (char *)malloc(streamsize + 1); - if (!membuf || (streamsize = fread(membuf, streamsize, 1, f)) == 0) { + if (!membuf || (streamsize = fread(membuf, 1, streamsize, f)) == 0) { report_error(tr("internal error: %s").toUtf8(), qt_error_string().toUtf8().data()); fclose(f); free((void *)membuf); -- cgit v1.2.3-70-g09d2