From 776f92edcf9e1fb563f8cae5bc49c54a85ff2faf Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Sat, 10 Nov 2012 20:02:21 +0100 Subject: Don't simplify 'bookmark' and 'heading' events Add the bookmark and heading events to the list of events not to be simplified just because they are redundant - in both cases they are about the user doing something explicit (like the gaschange), so even if the data is otherwise identical, they should likely be saved. That said, both events are kind of pointless (we don't actually seem to save the heading value for the heading events, and bookmarks are universally just due to user error in at least my case). But still.. This overly aggressive filtering was introduced in commit 6ad73a8f043b ("Improve logic handling events"). Signed-off-by: Linus Torvalds Signed-off-by: Dirk Hohndel --- dive.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dive.c b/dive.c index 4b894cb48..65cfc4d53 100644 --- a/dive.c +++ b/dive.c @@ -378,6 +378,10 @@ static gboolean is_potentially_redundant(struct event *event) { if (!strcmp(event->name, "gaschange")) return FALSE; + if (!strcmp(event->name, "bookmark")) + return FALSE; + if (!strcmp(event->name, "heading")) + return FALSE; return TRUE; } -- cgit v1.2.3-70-g09d2