From 9c8deef4774f335cbe66c64eb74397f228d41f5f Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Fri, 21 Sep 2018 13:23:36 +0200 Subject: Trivial: un-static function-local buffer In visit_on_node() in core/parse-xml.c the name is extracted into a static buffer. There seems to be no need for this being static, as the name is only passed to the entry() function which (hopefully) does not store a reference to the name anywhere. If it does, this would need a *big* *fat* comment. Signed-off-by: Berthold Stoeger --- core/parse-xml.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/parse-xml.c b/core/parse-xml.c index 3f2f3ea59..dd2250d21 100644 --- a/core/parse-xml.c +++ b/core/parse-xml.c @@ -1451,7 +1451,7 @@ static const char *nodename(xmlNode *node, char *buf, int len) static bool visit_one_node(xmlNode *node) { xmlChar *content; - static char buffer[MAXNAME]; + char buffer[MAXNAME]; const char *name; content = node->content; -- cgit v1.2.3-70-g09d2