From b0a00cd15de4b255139fefde3da36c28bd0b31bc Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sun, 27 Oct 2019 15:54:33 -0400 Subject: Cleanup: use helper to avoid NULL dereference We have these helper functions for exactly this purpose. Found by Coverity. Fixes CID 350129 Signed-off-by: Dirk Hohndel --- core/xmp_parser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/xmp_parser.cpp b/core/xmp_parser.cpp index c59e9a5bd..4ce6cef31 100644 --- a/core/xmp_parser.cpp +++ b/core/xmp_parser.cpp @@ -61,7 +61,7 @@ static timestamp_t extract_timestamp_from_attributes(const xmlNode *node) const xmlChar *ns = p->ns ? p->ns->prefix : nullptr; // Check for xmp::CreateDate property - if (!strcmp((const char *)ns, "xmp") && !strcmp((const char *)p->name, "CreateDate")) { + if (same_string((const char *)ns, "xmp") && same_string((const char *)p->name, "CreateDate")) { // We only support a single property value if (!p->children || !p->children->content) return 0; -- cgit v1.2.3-70-g09d2