From c1cd2e0f0295c569644c6d5ff186e00b4ce82d30 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Thu, 8 Feb 2018 22:05:29 +0100 Subject: core/imagedownloader.cpp: Fix memory leak A cloned picture struct would not be freed if the filename was already in the queued-for-download set. Signed-off-by: Berthold Stoeger --- core/imagedownloader.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/imagedownloader.cpp b/core/imagedownloader.cpp index 05900c40d..cdaa7fc90 100644 --- a/core/imagedownloader.cpp +++ b/core/imagedownloader.cpp @@ -86,8 +86,10 @@ static void loadPicture(struct picture *picture, bool fromHash) if (!picture) return; QMutexLocker locker(&pictureQueueMutex); - if (queuedPictures.contains(QString(picture->filename))) + if (queuedPictures.contains(QString(picture->filename))) { + picture_free(picture); return; + } queuedPictures.insert(QString(picture->filename)); locker.unlock(); -- cgit v1.2.3-70-g09d2