From efa4dc3c9a8a65935d05d3928675ab01a3aebb01 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Thu, 1 Oct 2015 07:52:13 -0400 Subject: Don't zoom out the globe if the dive site has no GPS This may or may not look intuitive, but it can cause problems with the zoom seemingly stuck all out (because of the timeouts). So instead stay where you are. If the current dive site has GPS then its flag will be bigger and brighter - so there still is visual feedback. But there's less crazy zooming around. Signed-off-by: Dirk Hohndel --- qt-ui/globe.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qt-ui/globe.cpp b/qt-ui/globe.cpp index a0866e475..135f195a1 100644 --- a/qt-ui/globe.cpp +++ b/qt-ui/globe.cpp @@ -251,7 +251,8 @@ void GlobeGPS::reload() void GlobeGPS::centerOnDiveSite(struct dive_site *ds) { if (!dive_site_has_gps_location(ds)) { - zoomOutForNoGPS(); + // this is not intuitive and at times causes trouble - let's comment it out for now + // zoomOutForNoGPS(); return; } qreal longitude = ds->longitude.udeg / 1000000.0; @@ -328,8 +329,9 @@ void GlobeGPS::prepareForGetDiveCoordinates() messageWidget->setCloseButtonVisible(false); messageWidget->animatedShow(); editingDiveLocation = true; - if (!dive_has_gps_location(current_dive)) - zoomOutForNoGPS(); + // this is not intuitive and at times causes trouble - let's comment it out for now + // if (!dive_has_gps_location(current_dive)) + // zoomOutForNoGPS(); } void GlobeGPS::changeDiveGeoPosition(qreal lon, qreal lat, GeoDataCoordinates::Unit unit) -- cgit v1.2.3-70-g09d2