From efb2640fc76dbba120c026831e0887c608ed4c66 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Tue, 26 Dec 2017 13:49:49 -0800 Subject: Cleanup: avoid memory leak The JUMP macro includes a 'goto bail', so we need to free devdata there Coverity CID 208340 Signed-off-by: Dirk Hohndel --- core/datatrak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/datatrak.c b/core/datatrak.c index 2f827c1bc..cb2222765 100644 --- a/core/datatrak.c +++ b/core/datatrak.c @@ -538,7 +538,6 @@ unsigned char *dt_dive_parser(unsigned char *runner, struct dive *dt_dive) } else { report_error(translate("gettextFromC", "[Error] Out of memory for dive %d. Abort parsing."), dt_dive->number); free(compl_buffer); - free(devdata); goto bail; } if (is_nitrox) @@ -566,6 +565,7 @@ unsigned char *dt_dive_parser(unsigned char *runner, struct dive *dt_dive) free(devdata); return membuf; bail: + free(devdata); return NULL; } /* -- cgit v1.2.3-70-g09d2